关闭

FW:W2A、OLE2A等 ATL 宏会引发 stack overflow。使用时注意

标签: macrosreturningstringeachinsertmfc
229人阅读 评论(0) 收藏 举报

http://blog.csdn.net/tg2003/archive/2009/07/10/4336930.aspx

最近一个转换文件的程序,在转换大批量文件是老是 stack overflow。
查来查去。。原来是 在大循环中用了W2A和A2W两个宏。
MSDN的 TN059: Using MFC MBCS/Unicode Conversion Macros 有描述,这两个宏在大循环中要有特殊的写法,不然保不准就 stack overflow。
Other Considerations

Do not use the macros in a tight loop. For example, you do not want to write the following kind of code:

void BadIterateCode(LPCTSTR lpsz)

{

   USES_CONVERSION;

   for (int ii = 0; ii < 10000; ii++)

      pI->SomeMethod(ii, T2COLE(lpsz));

}

The code above could result in allocating megabytes of memory on the stack depending on what the contents of the string lpsz is! It also takes time to convert the string for each iteration of the loop. Instead, move such constant conversions out of the loop:

void MuchBetterIterateCode(LPCTSTR lpsz)

{

   USES_CONVERSION;

   LPCOLESTR lpszT = T2COLE(lpsz);

   for (int ii = 0; ii < 10000; ii++)

      pI->SomeMethod(ii, lpszT);

}

If the string is not constant, then encapsulate the method call into a function. This will allow the conversion buffer to be freed each time. For example:

void CallSomeMethod(int ii, LPCTSTR lpsz)

{

   USES_CONVERSION;

   pI->SomeMethod(ii, T2COLE(lpsz));

}

void MuchBetterIterateCode2(LPCTSTR* lpszArray)

{

   for (int ii = 0; ii < 10000; ii++)

      CallSomeMethod(ii, lpszArray[ii]);

}

Never return the result of one of the macros, unless the return value implies making a copy of the data before the return. For example, this code is bad:

LPTSTR BadConvert(ISomeInterface* pI)

{

   USES_CONVERSION;

   LPOLESTR lpsz = NULL;

   pI->GetFileName(&lpsz);

   LPTSTR lpszT = OLE2T(lpsz);

   CoMemFree(lpsz);

   return lpszT; // bad! returning alloca memory

}

The code above could be fixed by changing the return value to something that copies the value:

CString BetterConvert(ISomeInterface* pI)

{

   USES_CONVERSION;

   LPOLESTR lpsz = NULL;

   pI->GetFileName(&lpsz);

   LPTSTR lpszT = OLE2T(lpsz);

   CoMemFree(lpsz);

   return lpszT; // CString makes copy

}

The macros are easy to use and easy to insert into your code, but as you can tell from the caveats above, you need to be careful when using them.

0
0

查看评论
* 以上用户言论只代表其个人观点,不代表CSDN网站的观点或立场
    个人资料
    • 访问:53555次
    • 积分:1359
    • 等级:
    • 排名:千里之外
    • 原创:94篇
    • 转载:1篇
    • 译文:0篇
    • 评论:5条
    最新评论