重构-改善既有代码的设计2010版读书笔记--步骤变化原因及记录一

最新推荐文章于 2024-05-03 00:12:05 发布

xingyuner2

最新推荐文章于 2024-05-03 00:12:05 发布

阅读量450

点赞数

分类专栏：重构-改善既有代码的设计读书笔记文章标签： Java 代码优化

本文链接：https://blog.csdn.net/xingyuner2/article/details/72614714

版权

重构-改善既有代码的设计读书笔记专栏收录该内容

1 篇文章 0 订阅

订阅专栏

第一个例子

第一个类：

影片类：

简单的纯数据类:

package one;

public class Movie {

public static final int REGULAR=0;
public static final int NEW_RELEASE=1;
public static final int CHILDRENS=2;

private String _title;
private int _priceCode;

public Movie(String title,int priceCode){
   _title=title;
   _priceCode=priceCode;
   }

public int getPriceCode() {
   return _priceCode;
}

public void setpriceCode(int arg) {
   _priceCode = arg;
}

public String getTitle(){
   return _title;
}
}

Rental(租赁)

Rental表示某顾客租了一部影片:

package one;
//租赁
class Rental {
private Movie _movie;
private int _daysRented;

public Rental(Movie movie, int daysRented) {
   _movie = movie;
   _daysRented = daysRented;
}

public int getDaysRented() {
   return _daysRented;
}

public Movie getMovie() {
   return _movie;
}

Customer（顾客）

Customer表示顾客，它也像其它类一样，它也拥有数据和相应的访问函数:

package one;

import java.util.Enumeration;
import java.util.Vector;

public class Customer {
private String _name;
private Vector _rentals=new Vector();

public Customer(String name){
   _name=name;
}
public void addRental(Rental arg){
   _rentals.addElement(arg);
}
public String getName(){
   return _name;
}

//Customer还提供了一个用于生成详单的函数:

public String statement(){
   double totalAmount=0;
   int frequentRenterPoints=0;
   Enumeration rentals=_rentals.elements();
   String result="Rental Record for "+getName()+"\n";
   while(rentals.hasMoreElements()){
       double thisAmount=0;
       Rental each=(Rental) rentals.nextElement();

       //determine qmounts for each line
       switch(each.getMovie().getPriceCode()){
       case Movie.REGULAR:
           thisAmount+=2;
           if(each.getDaysRented()>2)
               thisAmount +=(each.getDaysRented()-2)*1.5;
               break;
       case Movie.NEW_RELEASE:
           thisAmount+=each.getDaysRented()*3;
           break;
       case Movie.CHILDRENS:
               thisAmount +=1.5;
               if(each.getDaysRented()>3)
                   thisAmount+=(each.getDaysRented()-3)*1.5;
                   break;
       }
       //add frequent renter points
       frequentRenterPoints ++;
       //add bonus for a two day new release rental
       if((each.getMovie().getPriceCode()==Movie.NEW_RELEASE)&&each.getDaysRented()>1)
       frequentRenterPoints ++;
       //show figures for this rental
       result +="\t" +each.getMovie().getTitle()+"\t"+String.valueOf(thisAmount)+"\n";
       totalAmount+=thisAmount;
   }
       //add footer lines
       result+="Amount owed is"+String.valueOf(totalAmount)+"\n";
       result +="You earned"+String.valueOf(frequentRenterPoints)+"frequent renter points";
       return result;
   }
}

第一次重构:

分解并重组：

1，代码块越小，代码的功能就越容易管理，代码的处理和移动也就越轻松。

：提炼amountFor()函数并修改不喜欢的变量名:

package one;

import java.util.Enumeration;
import java.util.Vector;

public class Customer2 {
private String _name;
private Vector _rentals=new Vector();

public Customer2(String name){
   _name=name;
}
public void addRental(Rental arg){
   _rentals.addElement(arg);
}
public String getName(){
   return _name;
}
public String statement(){
   double totalAmount=0;
   int frequentRenterPoints=0;
   Enumeration rentals=_rentals.elements();
   String result="Rental Record for "+getName()+"\n";
   while(rentals.hasMoreElements()){
       double thisAmount=0;
       Rental each=(Rental) rentals.nextElement();

       thisAmount=amountFor(each);
       //System.out.println(thisAmount);
       //add frequent renter points
       frequentRenterPoints ++;
       //add bonus for a two day new release rental
       if((each.getMovie().getPriceCode()==Movie.NEW_RELEASE)&&each.getDaysRented()>1)
       frequentRenterPoints ++;
       //show figures for this rental
       result +="\t" +each.getMovie().getTitle()+"\t"+String.valueOf(thisAmount)+"\n";
       totalAmount+=thisAmount;
   }
       //add footer lines
       result+="Amount owed is"+String.valueOf(totalAmount)+"\n";
       result +="You earned"+String.valueOf(frequentRenterPoints)+"frequent renter points";
       return result;
}
private double amountFor(Rental aRental) {
     double result=0;
   //determine qmounts for each line
           switch(aRental.getMovie().getPriceCode()){
           case Movie.REGULAR:
               result+=2;
               if(aRental.getDaysRented()>2)
                   result +=(getDaysRented()-2)*1.5;
                   break;
           case Movie.NEW_RELEASE:
               result+=aRental.getDaysRented()*3;
               break;
           case Movie.CHILDRENS:
                   result +=1.5;
                   if(aRental.getDaysRented()>3)
                       result+=(aRental.getDaysRented()-3)*1.5;
                       break;
           }
   return result;
}
}
//这里作者忽略了thisAmount的返回类型，返回的是int,而不是double。应返回double。

//这里，作者顺便改变了amount里一些不喜欢的变量名

2，重要：函数应该放在它所使用的数据的所属对象内

：amountFor()应该移动到Rental类去

Rental类中：

double getCharge() {
   double result=0;
   //determine qmounts for each line
           switch(getMovie().getPriceCode()){
           case Movie.REGULAR:
               result+=2;
               if(getDaysRented()>2)
                   result +=(getDaysRented()-2)*1.5;
                   break;
           case Movie.NEW_RELEASE:
               result+=getDaysRented()*3;
               break;
           case Movie.CHILDRENS:
                   result +=1.5;
                   if(getDaysRented()>3)
                       result+=(getDaysRented()-3)*1.5;
                       break;
           }
   return result;
}

statement函数如下：

3，去除不必要的临时变量：

:去掉 thisAmount，用each.getCharge()代替。

:临时变量容易引发问题，它们会导致大量参数传来传去，而其实完全没有必要。在函数中,尤其是长长的函数中，还容易跟丢。

:当然这么做也会付出性能上的代价。此例中，getCharge()会被修改两遍。

:但是如果代码有良好的组织和管理，优化就会有很好的效果。

:这也是有时会困扰我的一个问题。既然可以这么处理，那挺好的。

4，提炼each.getFrequentRenterPoints()函数

:同2，此函数主要用到Rental里面的数据。提炼函数，可以让代码更简洁，耐看。

class Rental...

public int getFrequentRenterPoints() {
   if((getMovie().getPriceCode()==Movie.NEW_RELEASE)&&getDaysRented()>1){
       return 2;
   }else{
       return 1;
   }
}

5.去除临时变量:

:用Customer类的getTotalCharge()取代totalAmount()

:不得不复制循环。

class Customer...

public String statement(){
       int frequentRenterPoints=0;
       Enumeration rentals=_rentals.elements();
       String result="Rental Record for "+getName()+"\n";
       while(rentals.hasMoreElements()){
           Rental each=(Rental) rentals.nextElement();
           frequentRenterPoints=each.getFrequentRenterPoints();

           //show figures for this rental
           result +="\t" +each.getMovie().getTitle()+"\t"+String.valueOf(each.getCharge())+"\n";
       }
           //add footer lines
           result+="Amount owed is"+String.valueOf(getTotalCharge())+"\n";
           result +="You earned"+String.valueOf(frequentRenterPoints)+"frequent renter points";
           return result;
   }

private double getTotalCharge() {
       double result=0;
       Enumeration rentals=_rentals.elements();
       while(rentals.hasMoreElements()){
           Rental each=(Rental) rentals.nextElement();
           result+=each.getCharge();
       }
       return result;
   }

:相似的，用Customer类的getTotalFrequentRenterPoints()取代frequentRenterPoints。

public String statement(){
       Enumeration rentals=_rentals.elements();
       String result="Rental Record for "+getName()+"\n";
       while(rentals.hasMoreElements()){
           Rental each=(Rental) rentals.nextElement();

           //show figures for this rental
           result +="\t" +each.getMovie().getTitle()+"\t"+String.valueOf(each.getCharge())+"\n";
       }
           //add footer lines
           result+="Amount owed is"+String.valueOf(getTotalCharge())+"\n";
           result +="You earned"+String.valueOf(getTotalFrequentRenterPoints())+"frequent renter points";
           return result;
   }
   private int getTotalFrequentRenterPoints() {
       int result=0;
       Enumeration rentals=_rentals.elements();
       while(rentals.hasMoreElements()){
           Rental each=(Rental) rentals.nextElement();
           result+=each.getFrequentRenterPoints();
       }
       return result;
   }

6.把getCharge()放到Movie里去。

:此函数中用到的更多是Movie的属性

:把租借时间当参数传入。

class Movie..

double getCharge(int daysRented){
   double result=0;
       //determine qmounts for each line
               switch(getPriceCode()){
               case Movie.REGULAR:
                   result+=2;
                   if(daysRented>2)
                       result +=(daysRented-2)*1.5;
                       break;
               case Movie.NEW_RELEASE:
                   result+=daysRented*3;
                   break;
               case Movie.CHILDRENS:
                       result +=1.5;
                       if(daysRented>3)
                           result+=(daysRented-3)*1.5;
                           break;
               }
   return result;
}

class Rental...

double getCharge(){

return _movie.getCharge(_daysRented);

}

7,对getFrequentRenterPoints()也采取相应的策略。

class Movie..

int getFrequentRenterPoints(int daysRented){
   //add bonus for a two day new release rental
       if((getPriceCode()==Movie.NEW_RELEASE)&&daysRented>1){
           return 2;
       }else{
           return 1;
       }
}

class Rental...

public int getFreqentRenterPoints() {
return _movie.getFrequentRenterPoints(_daysRented);
}

8.继承

:数种影片类型，以不同的方式回答相同的问题----state模式。

:在Price对象内进行子类化动作，就可在任何必要时候修改价格。

:Replace Type Code with State/Strategy,将与类型相关的行为搬迁至State模式内。

:任何时候都通过取值函数和设值函数来访问类型代码。对构造函数加以改造。

class Novie

public Movie(String title,int priceCode){
   _title=title;
   setPriceCode(priceCode);
   }

:新建Price类，加入抽象函数，提供类型相关行为。在子类中加上对应的具体函数。

abstract class Price {
abstract int getPriceCode();

}

public class ChildrensPrice extends Price{
   int getPriceCode() {
       return Movie.CHILDRENS;
   }
}

public class NewReleasePrice extends Price{
   int getPriceCode() {
       return Movie.NEW_RELEASE;
   }
}
public class RegularPrice extends Price{
   int getPriceCode() {
       return Movie.REGULAR;
   }
}

:修改Movie类的"价格代号"访问函数(取值函数/设值函数)，让他们使用新类。

:不再保存_price-Code变量

class Movie..{

private Price _price;

public int getPriceCode() {
   return _price.getPriceCode();
}

public void setPriceCode(int arg) {
   switch(arg){
   case REGULAR:
       _price=new RegularPrice();
       break;
   case CHILDRENS:
       _price=new ChildrensPrice();
       break;
   case NEW_RELEASE:
       _price=new NewReleasePrice();
       break;
   default:
       throw new IllegalArgumentException("Incorrect Price Code");
   }
}

8.2 对getCharge()实施Move Method(142)

class Movie...

double getCharge(int daysRented){

return _price.getCharge(daysRented);

}

class Price...

double getCharge(int daysRented){
       double result=0;
           //determine qmounts for each line
                   switch(getPriceCode()){
                   case Movie.REGULAR:
                       result+=2;
                       if(daysRented>2)
                           result +=(daysRented-2)*1.5;
                           break;
                   case Movie.NEW_RELEASE:
                       result+=daysRented*3;
                       break;
                   case Movie.CHILDRENS:
                           result +=1.5;
                           if(daysRented>3)
                               result+=(daysRented-3)*1.5;
                               break;
                   }
       return result;
   }