Fragment强烈不推荐使用自定义带参的构造函数

项目在运行monkey63小时左右,出现9次CRASH:

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.aliyun.easylauncher/com.aliyun.easylauncher.dialpad.PhoneRecordActivity}: android.support.v4.app.Fragment$InstantiationException: Unable to instantiate fragment com.aliyun.easylauncher.dialpad.DialFragment: make sure class name exists, is public, and has an empty constructor that is public

正常的使用一切都是正常,Google后发现,Fragment有下面的注意事项:

public Fragment ()

Default constructor. Every fragment must have an empty constructor, so it can be instantiated when restoring its activity's state. It is strongly recommended that subclasses do not have other constructors with parameters, since these constructors will not be called when the fragment is re-instantiated; instead, arguments can be supplied by the caller with setArguments(Bundle) and later retrieved by the Fragment withgetArguments().

Applications should generally not implement a constructor. The first place application code an run where the fragment is ready to be used is in onAttach(Activity), the point where the fragment is actually associated with its activity. Some applications may also want to implementonInflate(Activity, AttributeSet, Bundle) to retrieve attributes from a layout resource, though should take care here because this happens for the fragment is attached to its activity.

看了一下frameworks/support/v4/java/android/support/v4/app/Fragment.java(因为import android.support.v4.app.Fragment)


 394     public static Fragment instantiate(Context context, String fname, Bundle args) {
   395         try {                    
   396             Class<?> clazz = sClassMap.get(fname);   
   397             if (clazz == null) { 
   398                 // Class not found in the cache, see if it's real, and try to add it
   399                 clazz = context.getClassLoader().loadClass(fname);
   400                 sClassMap.put(fname, clazz);             
   401             }                    
   402             Fragment f = (Fragment)clazz.newInstance(); //问题出在这里
   403             if (args != null) {  
   404                 args.setClassLoader(f.getClass().getClassLoader());
   405                 f.mArguments = args;
   406             }                    
   407             return f;            
   408         } catch (ClassNotFoundException e) {     
   409             throw new InstantiationException("Unable to instantiate fragment " + fname
   410                     + ": make sure class name exists, is public, and has an"
   411                     + " empty constructor that is public", e); 
   412         } catch (java.lang.InstantiationException e) {
   413             throw new InstantiationException("Unable to instantiate fragment " + fname
   414                     + ": make sure class name exists, is public, and has an"
   415                     + " empty constructor that is public", e); 
   416         } catch (IllegalAccessException e) {
   417             throw new InstantiationException("Unable to instantiate fragment " + fname
   418                     + ": make sure class name exists, is public, and has an"
   419                     + " empty constructor that is public", e);
   420         }
   421     

解决方案(来自stackoverflow),原文链接: http://stackoverflow.com/questions/10450348/do-fragments-really-need-an-empty-constructor


You shouldn't really be overriding the constructor anyway. You should have a newInstance() static method defined and pass any parameters via arguments (bundle)

For example:

public static final AlertFragment newInstance(int title, String message)
{
    AlertFragment f = new AlertFragment();
    Bundle bdl = new Bundle(2);
    bdl.putInt(EXTRA_TITLE, title);
    bdl.putString(EXTRA_MESSAGE, message);
    f.setArguments(bdl);
    return f;
}

And of course grabbing the args this way:

@Override
public void onCreate(Bundle savedInstanceState)
{
    title = getArguments().getInt(EXTRA_TITLE);
    message = getArguments().getString(EXTRA_MESSAGE);

    //...
    //etc
    //...
}

Then you would instantiate from your fragment manager like so:

public onCreate(Bundle savedInstanceState) {
    if(savedInstanceState == null){
        getSupportFragmentManager()
            .beginTransaction()
            .replace(R.id.content,AlertFragment.newInstance(
                R.string.alert_title,
                "Oh noes an error occured!")
            )
            .commit();
    }
}

This way if detached and re-attached the object state can be stored through the arguments. Much like bundles attached to Intents.



  • 9
    点赞
  • 11
    收藏
    觉得还不错? 一键收藏
  • 0
    评论

“相关推荐”对你有帮助么?

  • 非常没帮助
  • 没帮助
  • 一般
  • 有帮助
  • 非常有帮助
提交
评论
添加红包

请填写红包祝福语或标题

红包个数最小为10个

红包金额最低5元

当前余额3.43前往充值 >
需支付:10.00
成就一亿技术人!
领取后你会自动成为博主和红包主的粉丝 规则
hope_wisdom
发出的红包
实付
使用余额支付
点击重新获取
扫码支付
钱包余额 0

抵扣说明:

1.余额是钱包充值的虚拟货币,按照1:1的比例进行支付金额的抵扣。
2.余额无法直接购买下载,可以购买VIP、付费专栏及课程。

余额充值