java if 直接return,Java: if-return-if-return vs if-return-elseif-return

Neither one is more efficient than the other. The compiler can easily see that the two are identical, and in fact Suns/Oracles javac produces identical bytecode for the two methods.

Here is an IfTest class:

class IfTest {

public boolean eq1(Object obj) {

if (this == obj)

return true;

if (obj == null)

return false;

if (getClass() != obj.getClass())

return false;

return true;

}

public boolean eq2(Object obj) {

if (this == obj)

return true;

else if (obj == null)

return false;

else if (getClass() != obj.getClass())

return false;

return true;

}

}

I compiled it with javac and the disassembly is as follows:

public boolean eq1(java.lang.Object);

Code:

0: aload_0

1: aload_1

2: if_acmpne 7

5: iconst_1

6: ireturn

7: aload_1

8: ifnonnull 13

11: iconst_0

12: ireturn

13: aload_0

14: invokevirtual #2; //Method Object.getClass:()Ljava/lang/Class;

17: aload_1

18: invokevirtual #2; //Method Object.getClass:()Ljava/lang/Class;

21: if_acmpeq 26

24: iconst_0

25: ireturn

26: iconst_1

27: ireturn

public boolean eq2(java.lang.Object);

Code:

0: aload_0

1: aload_1

2: if_acmpne 7

5: iconst_1

6: ireturn

7: aload_1

8: ifnonnull 13

11: iconst_0

12: ireturn

13: aload_0

14: invokevirtual #2; //Method Object.getClass:()Ljava/lang/Class;

17: aload_1

18: invokevirtual #2; //Method Object.getClass:()Ljava/lang/Class;

21: if_acmpeq 26

24: iconst_0

25: ireturn

26: iconst_1

27: ireturn

That is, I would recommend using the first version (without the else). Some people may argue that it's cleaner with the else parts, but I would argue the opposite. Including the else indicates that the programmer didn't realize that it was unnecessary.