java 文件流关闭 finally,java试试finally块关闭流

I want to close my stream in the finally block, but it throws an IOException so it seems like I have to nest another try block in my finally block in order to close the stream. Is that the right way to do it? It seems a bit clunky.

Here's the code:

public void read() {

try {

r = new BufferedReader(new InputStreamReader(address.openStream()));

String inLine;

while ((inLine = r.readLine()) != null) {

System.out.println(inLine);

}

} catch (IOException readException) {

readException.printStackTrace();

} finally {

try {

if (r!=null) r.close();

} catch (Exception e){

e.printStackTrace();

}

}

}

解决方案

It seems a bit clunky.

It is. At least java7's try with resources fixes that.

Pre java7 you can make a closeStream function that swallows it:

public void closeStream(Closeable s){

try{

if(s!=null)s.close();

}catch(IOException e){

//Log or rethrow as unchecked (like RuntimException) ;)

}

}

Or put the try...finally inside the try catch:

try{

BufferedReader r = new BufferedReader(new InputStreamReader(address.openStream()));

try{

String inLine;

while ((inLine = r.readLine()) != null) {

System.out.println(inLine);

}

}finally{

r.close();

}

}catch(IOException e){

e.printStackTrace();

}

It's more verbose and an exception in the finally will hide one in the try but it's semantically closer to the try-with-resources introduced in Java 7.