Code Review中应该关注的点

1. Magic number/string

2. If statement, you should always use single line or brackets

3. Provide default value of Enum

4. Difference between abstract class and interface

5. Excess inheritance--the inheritance hierarchy is too deep

6. Use string.Concat, string.Format, StringBuilder instead of +

7. Const vs Readonly
8. Break down large method into small methods

9. Using nest class to hidden information is not necessary and hurts maintainability

10. Do not use new keyword to hidden base class's method, please use polymorphism
11. Static class may substitute singleton pattern for simplification
12. Private members/property access are not necessary if not protecting; use auto properties instead
13. Use IDisposable correctly to prevent resource leak for unmanaged resources.

14. Tell browser the encoding you are using with meta tag
15. Make sure browsers know you want to use edge rendering if you are building HTML5 websites
16. Eliminating embedded javascript and style sheets to help improve caching of your code
17. Use CDN so that browser caching can improve startup time for new users.
18. Reduced round-trips with fewer CSS files means you are less likely to run into browser limits of CSS
19. The less code inside a Razor file the better
20. Creating cached objects inside per-request classes is not necessary and adds complexity
21. Routing tables are still a valid way of doing routing for much your code

转载于:https://www.cnblogs.com/dereklovecc/p/4317272.html