java enum valueof 异常,不存在值时的Java Enum.valueOf（）效率

Which would you consider more efficient?

The use of 'WeekDay' is just an example:

public enum WeekDay {

MONDAY, TUESDAY, WEDNESDAY, THURSDAY, FRIDAY;

}

Loop through and verify day string first:

public void parseString(String line) {

String[] tokens = line.split();

String day = tokens[1]; // day 'should' always be a weekday

if (isValidWeekDay(day)) {

WeekDay weekDay = WeekDay.valueOf(day); // won't throw exception

...

} else {

throw new InvalidWeekDayException(day); // subclass of RuntimeException

}

}

private boolean isValidWeekDay(String day) {

for (WeekDay weekDay : WeekDay.values()) {

if(weekDay.toString().equals(day))

return true;

}

return false;

}

Or since in 99.99% of cases, day will be correct:

public void parseString(String line) {

String[] tokens = line.split();

String day = tokens[1]; // day 'should' always be a weekday

try {

WeekDay weekDay = WeekDay.valueOf(day); // might throw exception

...

} catch (IllegalArgumentException e) {

throw new InvalidWeekDayException(day, e);

}

}

Update:

To clarify, the input string will come from a client application, rather than a user. So in other words, it would be a bug to recieve a non workday in this example.

解决方案

I know its an old post, but I believe following result will be still interesting. I run 10000000 tests to find an element in enum ENUM {FIRST, SECOND, THIRD, FOURTH, LAST} using JDK 1.8. The table below shows time required by simple loop and valueOf().

text loop valueOf ratio

------------------------------

"FIRST" 121 65 186%

"LAST" 188 57 330%

"foo" 155 8958 1.7%

Conclusion - I wouldn't use valueOf() if I expect values not matching enum.