静态字段java,java – 从实例方法写入静态字段

我的代码如下.我知道了

public MyClass{

private static DataSource dataSource = null;

private static DataSource getDataSource(){

if (dataSource == null) {

try {

dataSource = // something.

} catch (Exception e) {

// some exception.

}

}

return dataSource;

}

public List doSomething(){

// ...

if(dataSource == null){

dataSource = getDataSource();

}

dataSource.getConnection();

// ...

}

}

我在声纳anaylsis中看到以下消息.

Dodgy - Write to static field from instance method

This instance method writes to a static field. This is tricky to get correct if multiple instances are being manipulated, and generally bad practice.

findbugs:ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD Sep12 Reliability > Architecture

我看到在这个实现中一切都没问题,只是我们正在改变doSomething方法中的静态变量.我们如何解决这个问题？

解决方法:

不确定您的静态分析工具如何工作,但是 –

尝试通过静态setter写入您的值：

private synchronized static void setDataSource(DataSource ds) {

dataSource = ds;

}

这样你就可以做到

if(dataSource == null){

setDataSource(getDataSource());

}

标签：java,sonarqube

来源： https://codeday.me/bug/20190825/1714621.html