问题现象
系统有时候会执行很慢,直接影响正常业务,使用jstack查看线程栈,发现有很多log4j 等待信息
Thread: checkSettDBHealthJobSchedule_Worker-8 : priority:5, demon:false, threadId:227, threadState:BLOCKED, lockName:org.apache.log4j.Logger@53fecdf6
org.apache.log4j.Category.callAppenders(Category.java:201)
org.apache.log4j.Category.forcedLog(Category.java:388)
org.apache.log4j.Category.log(Category.java:853)
org.slf4j.impl.Log4jLoggerAdapter.log(Log4jLoggerAdapter.java:602)
org.apache.commons.logging.impl.SLF4JLocationAwareLog.info(SLF4JLocationAwareLog.java:159)
com.star.sms.business.job.CheckDBHealthJob.start(CheckDBHealthJob.java:15)
sun.reflect.GeneratedMethodAccessor759.invoke(Unknown Source)
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
java.lang.reflect.Method.invoke(Unknown Source)
org.springframework.util.MethodInvoker.invoke(MethodInvoker.java:273)
org.springframework.scheduling.quartz.MethodInvokingJobDetailFactoryBean$MethodInvokingJob.executeInternal(MethodInvokingJobDetailFactoryBean.java:311)
org.springframework.scheduling.quartz.QuartzJobBean.execute(QuartzJobBean.java:113)
org.qartz.core.JobRunShell.run(JobRunShell.java:202)
org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)
Thread: checkSettDBHealthJobSchedule_Worker-9 : priority:5, demon:false, threadId:228, t
问题原因
查看Catelogry.callAppenders()在类别级别使用了一个同步块, log4j版本1.x中,使用的是古老的synchronized(this),所有线程共用一个Category,而它通过log4j.properties指定。 同一个Category下的线程打log时,需要进行全局同步,因此它的效率会很低,log4j 1.x版不适合高并发的场景。
/**
Call the appenders in the hierrachy starting at
<code>this</code>. If no appenders could be found, emit a
warning.
<p>This method calls all the appenders inherited from the
hierarchy circumventing any evaluation of whether to log or not
to log the particular log request.
@param event the event to log. */
public void callAppenders(LoggingEvent event) {
int writes = 0;
for(Category c = this; c != null; c=c.parent) {
// Protected against simultaneous call to addAppender, removeAppender,...
synchronized(c) {
if(c.aai != null) {
writes += c.aai.appendLoopOnAppenders(event);
}
if(!c.additive) {
break;
}
}
}
if(writes == 0) {
repository.emitNoAppenderWarning(this);
}
}