QT版的POP3协议实现

http://www.oschina.net/code/snippet_188882_32619#46915

最近公司的需要，做了一个QT版本的POP3协议实现，我感觉代码质量不是很好。希望大家帮忙看看，有哪些地方是可以改进的。

标签：  Qt

代码片段(4)[全屏查看所有代码]

1. [文件] mailreceiver.h ~ 1KB     下载(27)     

?

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47

#ifndef __MAIL_RECEIVER_H__ #define __MAIL_RECEIVER_H__ #include <QString> #include <QTcpSocket>   class MailReceiver: public QObject {      Q_OBJECT public :      struct MailData      {          unsigned int index;          QString id;          unsigned int size;      }; public :      MailReceiver(QString server,unsigned short port,QString username,QString password);      ~MailReceiver(){};        void setServer(QString server){m_server=server;}      void setPort(unsigned short port){m_port=port;}      void setUsername(QString username){m_username=username;}      void setPassword(QString password){m_password=password;}        QString getServer(){ return m_server;}      unsigned short getPort(){ return m_port;}      QString getUsername(){ return m_username;}      QString getPassword(){ return m_password;}      bool getConnected(){ return m_socket.state()==QAbstractSocket::ConnectedState;}      bool getLogin(){ return m_isLogin;}        virtual bool connectToServer()=0;      virtual bool login()=0;      virtual bool logoff()=0;      virtual bool list(std::vector<MailData> &result,unsigned int index=0)=0;      virtual bool retr(unsigned int index,QString &result)=0; protected slots:      virtual void socketDisconnected(); protected :      QString m_server;      unsigned short m_port;      QString m_username;      QString m_password;      QTcpSocket m_socket;      bool m_isLogin; }; #endif

2. [文件] mailreceiver.cpp ~ 434B     下载(19)     

?

1 2 3 4 5 6 7 8 9 10 11 12 13

#include "mailreceiver.h"   MailReceiver::MailReceiver(QString server,unsigned short port,QString username,QString password) :m_server(server),m_port(port),m_username(username),m_password(password),m_socket(NULL),m_isLogin( false ) {      m_socket.setSocketOption(QAbstractSocket::LowDelayOption,1);      connect(&m_socket,SIGNAL(disconnected()), this ,SLOT(socketDisconnected())); }   void MailReceiver::socketDisconnected() {      m_isLogin= false ; }

3. [文件] pop3receiver.h ~ 461B     下载(19)     

?

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18

#ifndef __POP3_RECEIVER_H__ #define __POP3_RECEIVER_H__ #include <vector> #include "mailreceiver.h"   class Pop3Receiver: public MailReceiver { public :      Pop3Receiver(QString server,unsigned short port,QString username,QString password)      :MailReceiver(server,port,username,password){}        bool connectToServer();      bool login();      bool logoff();      bool list(std::vector<MailData> &result,unsigned int index=0);      bool retr(unsigned int index,QString &result); }; #endif

4. [文件] pop3receiver.cpp ~ 5KB     下载(20)     

?

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233

#include <cstring> #include <cstdio> #include <QtDebug> #include <QRegExp> #include "pop3receiver.h"   bool Pop3Receiver::connectToServer() {      char buffer[1024];        m_socket. abort ();      m_socket.connectToHost(m_server,m_port);        if (!m_socket.waitForConnected())          return false ;      if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())          return false ;      memset (buffer,0, sizeof (buffer));      m_socket.readLine(buffer, sizeof (buffer));      if (buffer[0]!= '+' )          return false ;        return true ; }   bool Pop3Receiver::login() {      char buffer[1024];        if (!getConnected() || m_isLogin)          return false ;            /*Send username*/      memset (buffer,0, sizeof (buffer));      sprintf (buffer, "USER %s\r\n" ,m_username.toAscii().data());      m_socket.write(buffer);      m_socket.flush();      if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())          return false ;      memset (buffer,0, sizeof (buffer));      m_socket.readLine(buffer, sizeof (buffer));      if (buffer[0]!= '+' )          return false ;        /*send password*/      memset (buffer,0, sizeof (buffer));      sprintf (buffer, "PASS %s\r\n" ,m_password.toAscii().data());      m_socket.write(buffer);      m_socket.flush();      if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())          return false ;      memset (buffer,0, sizeof (buffer));      m_socket.readLine(buffer, sizeof (buffer));      if (buffer[0]!= '+' )          return false ;        /*set isLogin*/      m_isLogin= true ;            return true ; }   bool Pop3Receiver::logoff() {      char  buffer[1024];            if (!getConnected())          return false ;        /*Sendquit command*/      memset (buffer,0, sizeof (buffer));      sprintf (buffer, "QUIT\r\n" );      m_socket.write(buffer);      m_socket.flush();      if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())          return false ;      memset (buffer,0, sizeof (buffer));      m_socket.readLine(buffer, sizeof (buffer));      if (buffer[0]!= '+' )          return false ;        return true ; }   bool Pop3Receiver::list(std::vector<MailData> &result,unsigned int index) {      char buffer[1024];        if (!getConnected() || !m_isLogin)          return false ;            result.clear();      if (index!=0)      {          memset (buffer,0, sizeof (buffer));             sprintf (buffer, "LIST %u\r\n" ,index);          m_socket.write(buffer);          m_socket.flush();          if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())              return false ;          memset (buffer,0, sizeof (buffer));          m_socket.readLine(buffer, sizeof (buffer));          if (buffer[0]!= '+' )              return false ;                    MailData data;          sscanf (buffer, "+OK %u %u" ,&data.index,&data.size);          result.push_back(data);      }      else      {          memset (buffer,0, sizeof (buffer));             sprintf (buffer, "list\r\n" );          m_socket.write(buffer);          m_socket.flush();          if (!m_socket.waitForReadyRead())              return false ;          while ( true )          {              memset (buffer,0, sizeof (buffer));                   m_socket.waitForReadyRead(10);              m_socket.readLine(buffer, sizeof (buffer));              if (buffer[0]== '+' )              {                  /*                  if(!m_socket.waitForReadyRead())                      break;                  else                      continue;                  */                  continue ;              }              else if (buffer[0]== '-' )              {                  return false ;              }              else if (buffer[0]== '.' )              {                  //qDebug("End of list");                  break ;              }              else              {                  MailData data;                  sscanf (buffer, "%u %u" ,&data.index,&data.size);                  result.push_back(data);                  //qDebug()<<data.index<<"\t"<<data.size;              }          }      }        for (std::vector<MailData>::iterator iter=result.begin();iter!=result.end();iter++)      {          memset (buffer,0, sizeof (buffer));             sprintf (buffer, "UIDL %u\r\n" ,iter->index);          m_socket.write(buffer);          m_socket.flush();          if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())              continue ;          memset (buffer,0, sizeof (buffer));          m_socket.readLine(buffer, sizeof (buffer));          if (buffer[0]== '-' )          {              //qDebug()<<"Error get UIDL:"<<buffer;              continue ;          }                    QRegExp re( "(\\d+)\\s(\\S*)\r\n" );          if (re.indexIn(buffer,0)!=-1 && (unsigned int )re.cap(1).toInt()==iter->index)          {                  iter->id=re.cap(2);                   //qDebug()<<iter->index<<"\t"<<iter->id;          }          else          {              //qDebug()<<"Get no id:"<<buffer;          }      }        return true ;           }   bool Pop3Receiver::retr(unsigned int index,QString &result) {      char buffer[1024];        if (!getConnected() || !m_isLogin)          return false ;        result.clear();      memset (buffer,0, sizeof (buffer));      sprintf (buffer, "RETR %u\r\n" ,index);      m_socket.write(buffer);      m_socket.flush();      if (!m_socket.waitForReadyRead() || !m_socket.canReadLine())          return false ;      bool first= false ;      while (m_socket.canReadLine())      {          memset (buffer,0, sizeof (buffer));             m_socket.waitForReadyRead(5);          m_socket.readLine(buffer, sizeof (buffer));          //qDebug()<<buffer;          if (!first && buffer[0]== '+' )          {              /*              if(!m_socket.waitForReadyRead())                  break;              else                  continue;              */              first= true ;          }          else if (!first && buffer[0]== '-' )          {              qDebug()<< "RETR Error:" <<buffer;              first= true ;              return false ;          }          else if (buffer[0]== '.' )          {              //qDebug()<<"End of data";              break ;          }          else          {              result.append(buffer);          }      }      return true ; }