java迭代器异常 java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry

目的：高级计算机网络大作业--router（JAVA）

出错功能块：定时向邻居router发送Hello包

 

异常：

       Exception in thread "Timer-1" java.util.ConcurrentModificationException
            at java.util.HashMap$HashIterator.nextEntry(Unknown Source)
            at java.util.HashMap$EntryIterator.next(Unknown Source)
            at java.util.HashMap$EntryIterator.next(Unknown Source)
            at bit.cher.router.Router$2.run(Router.java:191)
            at java.util.TimerThread.mainLoop(Unknown Source)
            at java.util.TimerThread.run(Unknown Source)

报错位置：

        都是在it.next()引用迭代器的位置 （实际错误并不是该行代码的问题）

实际错误行：

       38  neighbors .remove(neighborId);  

       58  rt.completeRouteTable .remove((Integer)map.getKey()); 

错误原因：

         当集合A已经生成过iterator it之后，若要对此集合进行操作，只能访问it，不能够再次直接引用A

       38   neighbors已经生成过迭代器iSet，应该引用iSet而不能够再次引用 neighbors

       58  同理， rt.completeRouteTable已经有迭代器routeIt，应使用 routeIt进行remove

改正结果：

       38->35 iS et. remove();

       58->59 routeIt. remove();

出错源代码：

timer_Hello.schedule(new TimerTask(){ public void run() { Iterator iSet = neighbors.iterator(); boolean flag = false; // 标志路由是否已失效 String result = ""; routerArea.append("starting hello.../n"); while(iSet.hasNext()){ routerArea.append("while neighbor/n"); int neighborId = ((Integer)iSet.next()).intValue(); Socket s; try { s = new Socket(rl.getIp(neighborId), rl.getCommandPort(neighborId)); routerArea.append("socket/n"); ObjectInputStream ois; ObjectOutputStream oos; // open the streams associated with the connection ois = new ObjectInputStream(s.getInputStream()); oos = new ObjectOutputStream(s.getOutputStream()); // probe whether the router is up oos.writeObject("addRouter"); result = (String) ois.readObject(); routerArea.append("result:"+result+"/n"); ois.close(); oos.close(); s.close(); } catch (IOException e) { routerArea.append("Error occured when try saying hello to router" + neighborId + "./n"); } catch (ClassNotFoundException e) { routerArea.append(e.getMessage()); } // 如果该邻居是活动的，则检查下一个邻居 if (result.equals("true")) continue; else{ //若无法连接该邻居，则将其从邻居节点中移除，并将包含它的路由都删掉 neighbors.remove(neighborId); routerArea.append("1 "); Iterator routeIt = rt.completeRouteTable.entrySet().iterator(); routerArea.append("2 "); while(routeIt.hasNext()){ routerArea.append("3 "); routerArea.append(routeIt.toString()); Map.Entry map = (Map.Entry)routeIt.next(); LinkedList<Integer> routeList = (LinkedList<Integer>)map.getValue(); Iterator routerIt = routeList.iterator(); routerArea.append("4 "); while(routerIt.hasNext()){ routerArea.append("5 "); if(neighborId == (Integer)routerIt.next()){ flag = true; break; } } if(flag){ routerArea.append("6 "); rt.completeRouteTable.remove((Integer)map.getKey()); flag = false; } }//end route } }//end while neighbor routerArea.append("ending hello.../n"); } },6000);//每六秒执行一次

 

 

修改后源代码：

timer_Hello.schedule(new TimerTask(){ public void run() { Iterator iSet = neighbors.iterator(); boolean flag = false; // 标志路由是否已失效 String result = ""; routerArea.append("starting hello.../n"); while(iSet.hasNext()){ int neighborId = ((Integer)iSet.next()).intValue(); Socket s; try { s = new Socket(rl.getIp(neighborId), rl.getCommandPort(neighborId)); ObjectInputStream ois; ObjectOutputStream oos; // open the streams associated with the connection ois = new ObjectInputStream(s.getInputStream()); oos = new ObjectOutputStream(s.getOutputStream()); // probe whether the router is up oos.writeObject("addRouter"); result = (String) ois.readObject(); ois.close(); oos.close(); s.close(); } catch (IOException e) { routerArea.append("Error occured when try saying hello to router" + neighborId + "./n"); } catch (ClassNotFoundException e) { routerArea.append(e.getMessage()); } // 如果该邻居是活动的，则检查下一个邻居 if (result.equals("true")) continue; else{ //若无法连接该邻居，则将其从邻居节点中移除，并将包含它的路由都删掉 iSet.remove(); Iterator routeIt = rt.completeRouteTable.entrySet().iterator(); while(routeIt.hasNext()){ Map.Entry map = (Map.Entry)routeIt.next(); LinkedList<Integer> routeList = (LinkedList<Integer>)map.getValue(); Iterator routerIt = routeList.iterator(); while(routerIt.hasNext()){ if(neighborId == (Integer)routerIt.next()){ flag = true; break; } } if(flag){ routeIt.remove(); flag = false; } }//end route } }//end while neighbor routerArea.append("ending hello.../n"); } },6000);//每六秒执行一次