小细节导致假调用


private final A9Loader<List<E>> loader;
private final ThreadFactory factory;
private final int latch;
private final Semaphore procOrder = new Semaphore(0, false);
private final ExtedEntryA9cq<E> entryA9cq = new ExtedEntryA9cq<E>(false, 0);
private volatile int procLatch;
private volatile Future<E> refFuture;

... ...
private Future<E> asyncLoad() {
//check loading
final Future<E> current = refFuture;
if (current != null) return current;

// async load
ExecutorService executor = Executors.newSingleThreadExecutor(factory);
final Future<E> result = executor.submit(new Callable<E>() {

public E call() throws Exception {
final E nul = null;
try {
List<E> ls = loader.heavyLoad();
if (ls != null && ls.size() > 0) {
entryA9cq.append(ls);
}
procLatch = latch;
}
catch (Exception e) {
if (procLatch > 0) {
procLatch = -1;
loader.handleException(e);
}
else {
throw e;
}
}
finally {
try {
procOrder.acquire(); // waiting for 'refFuture = result'
}
finally {
refFuture = null;
}
}
return nul; // only a blocking mark
}
});
executor.shutdown();
refFuture = result;
procOrder.release();



上面的代码有问题,可能导致外层调用者永远进不到 "// async load 块"。
若是 while(true)调用,那么就死循环了。
(其中:entryA9cq 的方法都能保证原子性)

修改如下:

finally {
procOrder.acquireUninterruptibly(); // waiting for 'refFuture = result'
refFuture = null;
}
return nul; // only a blocking mark
}
});

refFuture = result;
procOrder.release(); // ensure the release.
executor.shutdown();
  • 0
    点赞
  • 0
    收藏
    觉得还不错? 一键收藏
  • 0
    评论
评论
添加红包

请填写红包祝福语或标题

红包个数最小为10个

红包金额最低5元

当前余额3.43前往充值 >
需支付:10.00
成就一亿技术人!
领取后你会自动成为博主和红包主的粉丝 规则
hope_wisdom
发出的红包
实付
使用余额支付
点击重新获取
扫码支付
钱包余额 0

抵扣说明:

1.余额是钱包充值的虚拟货币,按照1:1的比例进行支付金额的抵扣。
2.余额无法直接购买下载,可以购买VIP、付费专栏及课程。

余额充值