java生成10个随机数,在java中生成10位唯一随机数

I am trying with below code to generate 10 digits unique random number. As per my req i have to create around 5000 unique numbers(ids). This is not working as expected. It also generates -ve numbers. Also sometimes one or two digits are missing in generated number resulting in 8 or 9 numbers not 10.

public static synchronized List generateRandomPin(){

int START =1000000000;

//int END = Integer.parseInt("9999999999");

//long END = Integer.parseInt("9999999999");

long END = 9999999999L;

Random random = new Random();

for (int idx = 1; idx <= 3000; ++idx){

createRandomInteger(START, END, random);

}

return null;

}

private static void createRandomInteger(int aStart, long aEnd, Random aRandom){

if ( aStart > aEnd ) {

throw new IllegalArgumentException("Start cannot exceed End.");

}

//get the range, casting to long to avoid overflow problems

long range = (long)aEnd - (long)aStart + 1;

logger.info("range>>>>>>>>>>>"+range);

// compute a fraction of the range, 0 <= frac < range

long fraction = (long)(range * aRandom.nextDouble());

logger.info("fraction>>>>>>>>>>>>>>>>>>>>"+fraction);

int randomNumber = (int)(fraction + aStart);

logger.info("Generated : " + randomNumber);

}

解决方案

I think the reason you're getting 8/9 digit values and negative numbers is that you're adding fraction, a long (signed 64-bit value) which may be larger than the positive int range (32-bit value) to aStart.

The value is overflowing such that randomNumber is in the negative 32-bit range or has almost wrapped around to aStart (since int is a signed 32-bit value, fraction would only need to be slightly less than (2^32 - aStart) for you to see 8 or 9 digit values).

You need to use long for all the values.

private static void createRandomInteger(int aStart, long aEnd, Random aRandom){

if ( aStart > aEnd ) {

throw new IllegalArgumentException("Start cannot exceed End.");

}

//get the range, casting to long to avoid overflow problems

long range = aEnd - (long)aStart + 1;

logger.info("range>>>>>>>>>>>"+range);

// compute a fraction of the range, 0 <= frac < range

long fraction = (long)(range * aRandom.nextDouble());

logger.info("fraction>>>>>>>>>>>>>>>>>>>>"+fraction);

long randomNumber = fraction + (long)aStart;

logger.info("Generated : " + randomNumber);

}