项目场景:
在controller中使用@PathVariable注解能够正常使用,在做feign远程服务调用时却出了问题。
问题描述
情况对比:
controller中:
package com.xiaoma.controller;
import com.xiaoma.pojo.Member;
import com.xiaoma.service.MemberService;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;
import java.util.List;
@RestController
@RequestMapping("/shop/member")
public class MemberController {
@Autowired
MemberService memberService;
/**
* 根据id查询员工
* @param id 员工id
* @return 单个员工信息
*/
@GetMapping("/{id}")
public Member findById(@PathVariable Long id){
return memberService.findById(id);
}
}
创建测试GET http://localhost:8080/shop/member/1能够成功拿到数据库中的数据。
在做feign调用时:
feign接口MemberClient
package com.xiaoma.feign;
import com.xiaoma.pojo.Member;
import org.springframework.cloud.openfeign.FeignClient;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
@FeignClient("shop-user-provider")
public interface MemberClient {
@GetMapping("/shop/member/{id}")
Member findById(@PathVariable Long id);
}
服务消费者
package com.xiaoma.controller;
import com.xiaoma.feign.MemberClient;
import com.xiaoma.pojo.Member;
import com.xiaoma.service.MemberService;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;
import java.util.List;
@RestController
@RequestMapping("/shop/member")
public class MemberConsumerController {
@Autowired
MemberClient memberClient;
@GetMapping("/{id}")
public Member findById(@PathVariable Long id){
return memberClient.findById(id);
}
}
原因分析:
CTRL+左键点进去@PathVariable注解查看源码
我们在controller中只要id和/{id}相同会做默认赋值,
在做feign调用时需要指明id绑定的占位符参数位置,即@PathVariable("id")写法
/*
* Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.web.bind.annotation;
import java.lang.annotation.Documented;
import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
import org.springframework.core.annotation.AliasFor;
/**
* Annotation which indicates that a method parameter should be bound to a URI template
* variable. Supported for {@link RequestMapping} annotated handler methods.
*
* <p>If the method parameter is {@link java.util.Map Map<String, String>}
* then the map is populated with all path variable names and values.
*
* @author Arjen Poutsma
* @author Juergen Hoeller
* @since 3.0
* @see RequestMapping
* @see org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter
*/
@Target(ElementType.PARAMETER)
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface PathVariable {
/**
* Alias for {@link #name}.
*/
@AliasFor("name")
String value() default "";
/**
* The name of the path variable to bind to.
* @since 4.3.3
*/
@AliasFor("value")
String name() default "";
/**
* Whether the path variable is required.
* <p>Defaults to {@code true}, leading to an exception being thrown if the path
* variable is missing in the incoming request. Switch this to {@code false} if
* you prefer a {@code null} or Java 8 {@code java.util.Optional} in this case.
* e.g. on a {@code ModelAttribute} method which serves for different requests.
* @since 4.3.3
*/
boolean required() default true;
}
解决方案:
修改feign接口,指明id绑定的占位符参数位置,即@PathVariable("id")写法
package com.xiaoma.feign;
import com.xiaoma.pojo.Member;
import org.springframework.cloud.openfeign.FeignClient;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import java.util.List;
@FeignClient("shop-user-provider")
public interface MemberClient {
@GetMapping("/shop/member/{id}")
Member findById(@PathVariable("id") Long id);
}