自己第一次写的代码:
public int lengthOfLongestSubstring(String s) {
if (s == null || s.length() == 0) {
return 0;
}
HashMap<Character,Integer> newMap = new HashMap<>();
char[] charArr = s.toCharArray();
String temp = "";
int res = 0;
for (int i = 0;i < charArr.length;i++) {
if (!newMap.containsKey(charArr[i]) || newMap.get(charArr[i]) == -1) {
newMap.put(charArr[i],i);
temp += charArr[i];
continue;
}
int index = newMap.get(charArr[i]);
res = Math.max(res,temp.length());
temp = s.substring(newMap.get(charArr[i])+1, i+1);
for (Map.Entry<Character,Integer> entry : newMap.entrySet()) {
if (entry.getValue() <= index) {
newMap.put(entry.getKey(),-1);
}
}
newMap.put(charArr[i],i);
}
res = Math.max(res,temp.length());
return res;
}
改进点:
1.题目只要求返回子字符串的长度!没要求返回整个子字符串,所以没必要设置temp这个String类型的变量!更没有必要按照求出具体子字符串的思路去写代码!
2.遍历Hashma这个步骤太**了。
3.**********
改进后:
public int lengthOfLongestSubstring(String s) {
if (s == null || s.length() <= 0) {
return 0;
}
int max = 0;
int left = 0;
HashMap<Character,Integer> newMap = new HashMap<>();
for (int i = 0;i < s.length();i++) {
if (newMap.containsKey(s.charAt(i))) {
left = Math.max(left, newMap.get(s.charAt(i))+1);
}
max = Math.max(max, i - left + 1);
newMap.put(s.charAt(i),i);
}
return max;
}