2

Problem

\2. Add Two Numbers

Medium

You are given two non-empty linked lists representing two non-negative integers. The digits are stored in reverse order and each of their nodes contain a single digit. Add the two numbers and return it as a linked list.

You may assume the two numbers do not contain any leading zero, except the number 0 itself.

Example:

Input: (2 -> 4 -> 3) + (5 -> 6 -> 4)
Output: 7 -> 0 -> 8
Explanation: 342 + 465 = 807.

First Submit AC

/**
 * Definition for singly-linked list.
 * struct ListNode {
 *     int val;
 *     ListNode *next;
 *     ListNode(int x) : val(x), next(NULL) {}
 * };
 */
class Solution {
public:
	ListNode* addTwoNumbers(ListNode* l1, ListNode* l2) {
		ListNode* L = new ListNode(0);
		ListNode* P = L, *TemPtr(0);
		


		int flag = 0;
		int Tem;
		while (l1 && l2)
		{
			TemPtr = new ListNode(0);
			P->next = TemPtr;

			Tem = l1->val + l2->val + flag;
			if (Tem  > 9)
			{
				flag = 1;
				TemPtr->val = (Tem) - 10;
			}
			else
			{
				flag = 0;
				TemPtr->val = Tem;
			}

			l1 = l1->next;
			l2 = l2->next;
			P = TemPtr;
		} 
		while (l1)
		{
			TemPtr = new ListNode(0);
			P->next = TemPtr;

			Tem = l1->val +flag;
			if (Tem > 9)
			{
				flag = 1;
				TemPtr->val = (Tem)-10;
			}
			else
			{
				flag = 0;
				TemPtr->val = Tem;
			}

			l1 = l1->next;
			//l2 = l2->next;
			P = TemPtr;

		}
		while (l2)
		{
			TemPtr = new ListNode(0);
			P->next = TemPtr;

			Tem =  l2->val + flag;
			if (Tem > 9)
			{
				flag = 1;
				TemPtr->val = (Tem)-10;
			}
			else
			{
				flag = 0;
				TemPtr->val = Tem;
			}

			//l1 = l1->next;
			l2 = l2->next;
			P = TemPtr;
		}
        /*if(flag == 1)
        {
            P->next = new ListNode(1);
        }*/
		return L->next;


	}
};

提交问题：

1. 忘记最后一位可能进一位，类比两个数相加，在return前要有flag的进位判断
2. 你的代码太长了，复用性差，可以用函数Insert!
3. 你没有分配内存判断是否分配成功！new , malloc

Online Way

1. 利用?:三目运算符来简化if-else+赋值语句
2. 对某个数求余还是if-else需要cutoff,tradeoff,有的时候可读性更重要

Improve Field

简化和复用代码：函数

Reduced Code

#include<iostream>
#include<vector>
#include<algorithm>
using namespace std;
/**
 * Definition for singly-linked list.
 * struct ListNode {
 *     int val;
 *     ListNode *next;
 *     ListNode(int x) : val(x), next(NULL) {}
 * };
 */
struct ListNode {
	int val;
	ListNode *next;
	ListNode(int x) : val(x), next(NULL) {}
	
};
class Solution {
	
public:
	void Insert(ListNode* &P, int X)
	{
		ListNode * Tmp= new ListNode(X);
		if (!Tmp)
		{
			cout << "Memory Insert error!\n" << endl;
			exit(1);
		}
		P->next = Tmp;
		P = Tmp;
	
	}
	void IncreseBit(int &Tem, int &flag, int a, int b, ListNode *&P)
	{
		Tem = a + b + flag;
		if (Tem > 9)
		{
			flag = 1;
			Insert(P, (Tem)-10);
		}
		else
		{
			flag = 0;
			Insert(P, Tem);
		}
	}
	ListNode* addTwoNumbers1(ListNode* l1, ListNode* l2) {
		ListNode* L = new ListNode(0);
		ListNode* P = L, *TemPtr(0);
		


		int flag = 0;
		int Tem;
		while (l1 && l2)
		{
			TemPtr = new ListNode(0);
			P->next = TemPtr;

			Tem = l1->val + l2->val + flag;
			if (Tem  > 9)
			{
				flag = 1;
				TemPtr->val = (Tem) - 10;
			}
			else
			{
				flag = 0;
				TemPtr->val = Tem;
			}

			l1 = l1->next;
			l2 = l2->next;
			P = TemPtr;
		} 
		while (l1)
		{
			TemPtr = new ListNode(0);
			P->next = TemPtr;

			Tem = l1->val +flag;
			if (Tem > 9)
			{
				flag = 1;
				TemPtr->val = (Tem)-10;
			}
			else
			{
				flag = 0;
				TemPtr->val = Tem;
			}

			l1 = l1->next;
			l2 = l2->next;
			P = TemPtr;

		}
		while (l2)
		{
			TemPtr = new ListNode(0);
			P->next = TemPtr;

			Tem =  l2->val + flag;
			if (Tem > 9)
			{
				flag = 1;
				TemPtr->val = (Tem)-10;
			}
			else
			{
				flag = 0;
				TemPtr->val = Tem;
			}

			l1 = l1->next;
			l2 = l2->next;
			P = TemPtr;
		}
		if (flag == 1)
		{
			P->next = new ListNode(1);
		}
		return L->next;


	}
	ListNode* addTwoNumbers(ListNode* l1, ListNode* l2) {
		ListNode* L = new ListNode(0);
		ListNode* P = L, *TemPtr(0);

		int flag = 0;
		int Tem;
		
		int a, b;
		while (l1 || l2)
		{
			if (l1) {
				a = l1->val; l1 = l1->next;
			}
			if (l2) {
				b = l2->val; l2 = l2->next;
			}
			IncreseBit(Tem, flag, a, b, P);
			a = b = 0;
		}
		if (flag == 1)
		{
			Insert(P, 1);
		}
		return L->next;


	}
};
int main()
{
	Solution Obj;
	ListNode *A = new ListNode(2), *B = new ListNode(5);
	ListNode *Re = Obj.addTwoNumbers(A, B);
	cout << Re->val << endl;
	system("pause");
	return 0;
}

Tips Learning

1. ?:用法

   int a = 5;
   itn b = 6;
   int tem = (a > b)?a:b;
   int a = (a > b)? b:a;