Java层级目录树——代码重构
一、问题分析
生成层级目录树
1.参数——节点数据集合
2.函数名——convertToTreeList
3.返回值——void
=> void convertToTreeList(List original);
二、方法对比
<Node, T> List getTreeList(List nodes, Function<Node, T> getId, Function<Node, T> getPid, Function<Node, List> getChildren);
void convertToTreeList(List<Node> original);
分析:getTreeList方法 1.参数过长 2.冗余的返回值 3.毫无关联的泛型
三、代码实现
1.节点数据
package utils;
import lombok.Data;
import java.util.ArrayList;
import java.util.List;
@Data
public class TempNode<T extends Number> {
private T id;
private T pid;
private List<TempNode<T>> children;
public TempNode() {
children = new ArrayList<>();
}
public TempNode(T id, T pid) {
children = new ArrayList<>();
this.id = id;
this.pid = pid;
}
}
- 方法实现
public static <T extends Number> void convertToTreeList(List<TempNode<T>> original) {
Map<T, List<TempNode<T>>> nodeMap = original.stream()
.filter(tempNode -> tempNode.getPid() != null)
.collect(Collectors.groupingBy(TempNode::getPid, Collectors.toList()));
original.forEach(tempNode -> {
List<TempNode<T>> children = nodeMap.get(tempNode.getId());
if (children != null && !children.isEmpty()) {
tempNode.getChildren().addAll(children);
}
});
}
四、方法测试
测试方法
public static void main(String[] args) {
List<TempNode<Integer>> tempNodes = getTempNodes();
System.out.println(tempNodes);
TreeListUtil.convertToTreeList(tempNodes);
System.err.println(tempNodes);
}
static List<TempNode<Integer>> getTempNodes() {
List<TempNode<Integer>> result = new ArrayList<>();
TempNode<Integer> temp1 = new TempNode<>(1, null);
TempNode<Integer> temp2 = new TempNode<>(2, 1);
TempNode<Integer> temp3 = new TempNode<>(3, 2);
TempNode<Integer> temp4 = new TempNode<>(4, 2);
TempNode<Integer> temp5 = new TempNode<>(5, 3);
TempNode<Integer> temp6 = new TempNode<>(6, 5);
TempNode<Integer> temp7 = new TempNode<>(7, 4);
TempNode<Integer> temp8 = new TempNode<>(8, 5);
result.add(temp1);
result.add(temp2);
result.add(temp3);
result.add(temp4);
result.add(temp5);
result.add(temp6);
result.add(temp7);
result.add(temp8);
return result;
}
测试结果(代码运行结果)
[TempNode(id=1, pid=null, children=[]), TempNode(id=2, pid=1, children=[]), TempNode(id=3, pid=2, children=[]), TempNode(id=4, pid=2, children=[]), TempNode(id=5, pid=3, children=[]), TempNode(id=6, pid=5, children=[]), TempNode(id=7, pid=4, children=[]), TempNode(id=8, pid=5, children=[])]
[TempNode(id=1, pid=null, children=[TempNode(id=2, pid=1, children=[TempNode(id=3, pid=2, children=[TempNode(id=5, pid=3, children=[TempNode(id=6, pid=5, children=[]), TempNode(id=8, pid=5, children=[])])]), TempNode(id=4, pid=2, children=[TempNode(id=7, pid=4, children=[])])])]), TempNode(id=2, pid=1, children=[TempNode(id=3, pid=2, children=[TempNode(id=5, pid=3, children=[TempNode(id=6, pid=5, children=[]), TempNode(id=8, pid=5, children=[])])]), TempNode(id=4, pid=2, children=[TempNode(id=7, pid=4, children=[])])]), TempNode(id=3, pid=2, children=[TempNode(id=5, pid=3, children=[TempNode(id=6, pid=5, children=[]), TempNode(id=8, pid=5, children=[])])]), TempNode(id=4, pid=2, children=[TempNode(id=7, pid=4, children=[])]), TempNode(id=5, pid=3, children=[TempNode(id=6, pid=5, children=[]), TempNode(id=8, pid=5, children=[])]), TempNode(id=6, pid=5, children=[]), TempNode(id=7, pid=4, children=[]), TempNode(id=8, pid=5, children=[])]