oracle触发器

goodsdoc上触发器校验生成厂家不能为空

create or replace trigger tr_goods
before insert or update on goodsdoc
for each row
begin
  if :new.manufacturer is null then
    RAISE_APPLICATION_ERROR(-20991, '生成厂家为空！');
  end if;
end tr_goods;

--------------------------------------------------------------------------------------------------

create or replace trigger test

  before insert on goodsdoc  
  for each row 
when (:new.billno = 0)
declare
  -- local variables here
begin
  select s_userid.nextval into :new.billno from dual;
end test;