[重构]1.关于提炼方法,变量,类

最新推荐文章于 2022-06-21 02:14:22 发布

只要你一直跑

最新推荐文章于 2022-06-21 02:14:22 发布

阅读量288

点赞数

分类专栏：学习笔记文章标签： refactoring 重构代码简洁

本文链接：https://blog.csdn.net/lingfy1234/article/details/121708972

版权

学习笔记专栏收录该内容

38 篇文章 1 订阅

订阅专栏

1.提炼方法

该提炼方法:

方法太长的时候需要提炼，否则太长的函数难以阅读，每个方法6行以内是最好的
用来代替只用一次的临时变量，如果有一个临时变量只要用一次，它是由一系列步骤生成的，那么可以用方法来代替这个临时变量,比如：

double avgScope= total / number;
if (avgScope < 10) {
	return "Good";
}

变成：

if (avgScope() < 10) {
	return "Good";
}
private avgScope(){
	return total / number;
}

不该提炼方法：

方法内容其实很简单，不提炼比提炼更容易理解，这个时候不需要提炼

2.提炼变量

该提炼：

用boolean类型临时变量来代替一个复杂的条件，这个时候变量会更简洁

// BAD CODE
if((quantity > 50) || ((quantity * price) > 500)) {
  quantityDiscount = .10;
} else if((quantity > 25) || ((quantity * price) > 100)) {
  quantityDiscount = .07;
 } else if((quantity >= 10) || ((quantity * price) > 50)) {
uantityDiscount = .05;
}

// GOOD CODE
final boolean over50Products = (quantity > 50) || ((quantity * price) > 500);

final boolean over25Products = (quantity > 25) || ((quantity * price) > 100);

final boolean over10Products = (quantity >= 10) || ((quantity * price) > 50);

if(over50Products) {
  quantityDiscount = .10;
} else if(over25Products) {
  quantityDiscount = .07;
} else if(over10Products) {
  quantityDiscount = .05;
}

有很多一个复杂的四则运算，应该用临时变量来代替某些复杂计算的整体

// BAD CODE
System.out.println("Total cost for " + product.getQuantity() + " " + product.getName() + "s is $" + product.getTotalCost());
System.out.println("Cost per product " + product.getTotalCost() / product.getQuantity());
System.out.println("Savings per product " + ((product.getPrice() + product.getShippingCost()) - (product.getTotalCost() / product.getQuantity())) + "\n");

// GOOD CODE
final int numOfProducts = product.getQuantity(); 
final String prodName = product.getName();
final double cost = product.getTotalCost();
final double costWithDiscount = product.getTotalCost() / product.getQuantity();
final double costWithoutDiscount = product.getPrice() + product.getShippingCost();
System.out.println("Total cost for " + numOfProducts + " " + prodName + "s is $" + cost);
System.out.println("Cost per product " + costWithDiscount);
System.out.println("Savings per product " + (costWithoutDiscount - costWithDiscount));
System.out.println()

注意：不应该用同一个临时变量来表示多个不同的运算状态

// BAD CODE
double price = totalCost / numberOfProducts;
price = price + shipping;
price = temp - discount;

// GOOD CODE
double individualPrice = totalCost / numberOfProducts;
double individualPriceWithShipping = individualPrice + shipping;
double price = individualPriceWithShipping - discount;