CSAPP ShellLab[出现的问题与解决方法]

shell Lab

本文不是专门的教程，只记录一些问题。如果恰好有和我一样的问题，欢迎探讨！

问题1：用waitpid(-1,NULL,0)导致前台程序很快运行并返回后shell发生阻塞，（因为前台和后台都算父进程的子进程），造成父进程等待后台子进程，而影响了之后语句的输入。
解决1：将waitpid的默认行为变成WNOHANG|WUNTRACED，回收子进程然后立即返回，不做任何停留。

问题2：处理Ctrl C（前台进程全部关闭）和Ctrl Z（前台进程全部暂停）在joblist中的行为时，要放入sigchld_handler中，而不是sigint_handler或sigtstp_handler。因为最终对终止/暂停进程的处理还是要通过sigchld_handler来完成。
解决2：将waitpid(-1,NULL,WNOHANG|WUNTRACED) 变为waitpid(-1 &state,WNOHANG|WUNTRACED),根据返回的state来确定这是“因为中断信号造成的退出”还是“正常退出”还是“暂停”

问题3：涉及到C的指针操作，详情见代码

	struct job_t thisJob;//本次job
	if(number[0]=='%')	{
		jid=atoi(number+1);//important
		if(getjobjid(jobs, jid)==NULL){
			printf("No such job exists");
			return;			
		}
		thisJob= *getjobjid(jobs, jid);
	}
	else {
		pid=atoi(number);
		if(getjobpid(jobs, pid)==NULL){
			printf("No such job exists");
			return;					
		}
		thisJob= *getjobpid(jobs, pid);
	}
	pid=(*thisJob).pid; 
	if(!strcmp(argv[0],"bg")){
		printf("[%d] (%d) %s",pid2jid(pid),pid,(*thisJob).cmdline);
		thisJob.state=BG;	
	}
	if(!strcmp(argv[0],"fg")){
		thisJob.state=FG;
	}

这里我们设定thisjob是根据id返回的指针的取内容，也就是id对应的job。为什么我直接将他的状态修改就不对呢？
这里我经过不断的调试发现，新建一个空结构体并将jobs指针中的内容传给他，相当于得到了对应内容的一个副本，并不是原有的内容。要想真正实现在原有空间上的改动，还是只能通过指针操作，代码如下：

	struct job_t* thisJob;//本次job
	if(number[0]=='%')	{
		jid=atoi(number+1);//important
		if(getjobjid(jobs, jid)==NULL){
			printf("No such job exists");
			return;			
		}
		thisJob=getjobjid(jobs, jid);
	}
	else {
		pid=atoi(number);
		if(getjobpid(jobs, pid)==NULL){
			printf("No such job exists");
			return;					
		}
		thisJob=getjobpid(jobs, pid);
	}
	pid=(*thisJob).pid; 
	if(!strcmp(argv[0],"bg")){
		printf("[%d] (%d) %s",pid2jid(pid),pid,(*thisJob).cmdline);
		thisJob->state=BG;	
	}
	if(!strcmp(argv[0],"fg")){
		thisJob->state=FG;
		waitfg(pid);
	}
	kill(-pid,SIGCONT);	  
 	sigprocmask(SIG_BLOCK,&mask_all,&prev_all);
	return; 

问题4：
在fg指令后，将进程切换到前台，一定不要忘了加一个等待的waitfg(pid)，否则系统会将其视为后台，直接开始执行下一条指令。

最后粘一下代码，所有例子都AC：

/* 
 * tsh - A tiny shell program with job control
 * 
 * <Put your name and login ID here>
 */
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <ctype.h>
#include <signal.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <errno.h>

/* Misc manifest constants */
#define MAXLINE    1024   /* max line size */
#define MAXARGS     128   /* max args on a command line */
#define MAXJOBS      16   /* max jobs at any point in time */
#define MAXJID    1<<16   /* max job ID */

/* Job states */
#define UNDEF 0 /* undefined */
#define FG 1    /* running in foreground */
#define BG 2    /* running in background */
#define ST 3    /* stopped */

/* 
 * Jobs states: FG (foreground), BG (background), ST (stopped)
 * Job state transitions and enabling actions:
 *     FG -> ST  : ctrl-z
 *     ST -> FG  : fg command
 *     ST -> BG  : bg command
 *     BG -> FG  : fg command
 * At most 1 job can be in the FG state.
 */

/* Global variables */
extern char **environ;      /* defined in libc */
char prompt[] = "tsh> ";    /* command line prompt (DO NOT CHANGE) */
int verbose = 0;            /* if true, print additional output */
int nextjid = 1;            /* next job ID to allocate */
char sbuf[MAXLINE];         /* for composing sprintf messages */
struct job_t {              /* The job struct */
    pid_t pid;              /* job PID */
    int jid;                /* job ID [1, 2, ...] */
    int state;              /* UNDEF, BG, FG, or ST */
    char cmdline[MAXLINE];  /* command line */
};
struct job_t jobs[MAXJOBS]; /* The job list */
/* End global variables */


/* Function prototypes */

/* Here are the functions that you will implement */
void eval(char *cmdline);
int builtin_cmd(char **argv);
void do_bgfg(char **argv);
void waitfg(pid_t pid);

void sigchld_handler(int sig);
void sigtstp_handler(int sig);
void sigint_handler(int sig);

/* Here are helper routines that we've provided for you */
int parseline(const char *cmdline, char **argv); 
void sigquit_handler(int sig);

void clearjob(struct job_t *job);
void initjobs(struct job_t *jobs);
int maxjid(struct job_t *jobs); 
int addjob(struct job_t *jobs, pid_t pid, int state, char *cmdline);
int deletejob(struct job_t *jobs, pid_t pid); 
pid_t fgpid(struct job_t *jobs);
struct job_t *getjobpid(struct job_t *jobs, pid_t pid);
struct job_t *getjobjid(struct job_t *jobs, int jid); 
int pid2jid(pid_t pid); 
void listjobs(struct job_t *jobs);

void usage(void);//                                                              Y
void unix_error(char *msg);
void app_error(char *msg);
typedef void handler_t(int);
handler_t *Signal(int signum, handler_t *handler);

/*
 * main - The shell's main routine 
 */
int main(int argc, char **argv) 
{
    char c;
    char cmdline[MAXLINE];
    int emit_prompt = 1; /* emit prompt (default) */

    /* Redirect stderr to stdout (so that driver will get all output
     * on the pipe connected to stdout) */
    dup2(1, 2);

    /* Parse the command line */
    while ((c = getopt(argc, argv, "hvp")) != EOF) {
        switch (c) {
        case 'h':             /* print help message */
            usage();
	    break;
        case 'v':             /* emit additional diagnostic info */
            verbose = 1;
	    break;
        case 'p':             /* don't print a prompt */
            emit_prompt = 0;  /* handy for automatic testing */
	    break;
	default:
            usage();
	}
    }

    /* Install the signal handlers */

    /* These are the ones you will need to implement */
    Signal(SIGINT,  sigint_handler);   /* ctrl-c */
    Signal(SIGTSTP, sigtstp_handler);  /* ctrl-z */
    Signal(SIGCHLD, sigchld_handler);  /* Terminated or stopped child */

    /* This one provides a clean way to kill the shell */
    Signal(SIGQUIT, sigquit_handler); 

    /* Initialize the job list */
    initjobs(jobs);

    /* Execute the shell's read/eval loop */
    while (1) {

	/* Read command line */
	if (emit_prompt) {
	    printf("%s", prompt);
	    fflush(stdout);
	}
	if ((fgets(cmdline, MAXLINE, stdin) == NULL) && ferror(stdin))
	    app_error("fgets error");
	if (feof(stdin)) { /* End of file (ctrl-d) */
	    fflush(stdout);
	    exit(0);
	}

	/* Evaluate the command line */
	eval(cmdline);
	fflush(stdout);
	fflush(stdout);
    } 

    exit(0); /* control never reaches here */
}
  
/* 
 * eval - Evaluate the command line that the user has just typed in
 * 
 * If the user has requested a built-in command (quit, jobs, bg or fg)
 * then execute it immediately. Otherwise, fork a child process and
 * run the job in the context of the child. If the job is running in
 * the foreground, wait for it to terminate and then return.  Note:
 * each child process must have a unique process group ID so that our
 * background children don't receive SIGINT (SIGTSTP) from the kernel
 * when we type ctrl-c (ctrl-z) at the keyboard.  
*/
void eval(char *cmdline) 
{
	char* argvList[MAXARGS];//新建字符串数组argvList存放参数们
	char buf[MAXLINE];
	int bg,state;//当前cmdline是bg还是fg
	pid_t pid;//当前新开进程的编号
	sigset_t mask_all,mask_one,prev_one;

	
	strcpy(buf,cmdline);
	bg=parseline(buf,argvList);
	if(argvList[0]==NULL)
		return;//空指令
	
	if(!builtin_cmd(argvList)){
		sigfillset(&mask_all);
		sigemptyset(&mask_one);
		sigaddset(&mask_one,SIGCHLD);
		sigprocmask(SIG_BLOCK,&mask_one,&prev_one);
		if((pid=fork())==0){
			setpgid(0,0);//指定新的进程组，将新开的进程放到这个进程组里面。
			sigprocmask(SIG_SETMASK,&prev_one,NULL);

			if(execvp(argvList[0],argvList)<0){
				printf("%s:Command not found.\n",argvList[0]);
				exit(0);
			}
			
		}
    	state = (bg==1) ? BG : FG;
            //阻塞所有信号
    	sigprocmask(SIG_BLOCK, &mask_all, NULL);
    	addjob(jobs, pid, state, cmdline);
    	sigprocmask(SIG_SETMASK, &prev_one, NULL);
		//sigprocmask(SIG_BLOCK,&mask_all,NULL);
		//if(addjob(jobs, pid, bg+1, cmdline)==1){
		//sigprocmask(SIG_SETMASK,&prev_one,NULL);
		if(bg==1){
			//printf("background, pid is %d,jid is %d \n",pid,pid2jid(pid));
			printf("[%d] (%d) %s",pid2jid(pid),pid,cmdline);
		}
		else{
			//printf("foreground, pid is %d,jid is %d \n",pid,pid2jid(pid));
			waitfg(pid);
		}

				
	}
    return;



}

/* 
 * parseline - Parse the command line and build the argv array.
 * 
 * Characters enclosed in single quotes are treated as a single
 * argument.  Return true if the user has requested a BG job, false if
 * the user has requested a FG job.  
 */
int parseline(const char *cmdline, char **argv) 
{
    static char array[MAXLINE]; /* holds local copy of command line */
    char *buf = array;          /* ptr that traverses command line */
    char *delim;                /* points to first space delimiter */
    int argc;                   /* number of args */
    int bg;                     /* background job? */

    strcpy(buf, cmdline);
    buf[strlen(buf)-1] = ' ';  /* replace trailing '\n' with space */
    while (*buf && (*buf == ' ')) /* ignore leading spaces */
	buf++;

    /* Build the argv list */
    argc = 0;
    if (*buf == '\'') {
	buf++;
	delim = strchr(buf, '\'');
    }
    else {
	delim = strchr(buf, ' ');
    }

    while (delim) {
	argv[argc++] = buf;
	*delim = '\0';
	buf = delim + 1;
	while (*buf && (*buf == ' ')) /* ignore spaces */
	       buf++;

	if (*buf == '\'') {
	    buf++;
	    delim = strchr(buf, '\'');
	}
	else {
	    delim = strchr(buf, ' ');
	}
    }
    argv[argc] = NULL;
    
    if (argc == 0)  /* ignore blank line */
	return 1;

    /* should the job run in the background? */
    if ((bg = (*argv[argc-1] == '&')) != 0) {
	argv[--argc] = NULL;
    }
    return bg;
}

/* 
 * builtin_cmd - If the user has typed a built-in command then execute
 *    it immediately.  
 */
int builtin_cmd(char **argv) 
{
	if(!strcmp(argv[0],"quit")){
		exit(0);
	}
	if(!strcmp(argv[0],"jobs")){
		listjobs(jobs) ;//目前还没有改为输出所有后台信号
		return 1;
	}
	if(!strcmp(argv[0],"bg")){
		do_bgfg(argv);
		return 1;
	}
	if(!strcmp(argv[0],"fg")){
		do_bgfg(argv);
		return 1;
	}
	if(!strcmp(argv[0],"&")){
		return 1;
	}
    return 0;     /* not a builtin command */
}

/* 
 * do_bgfg - Execute the builtin bg and fg commands
 */
void do_bgfg(char **argv) 
{
	int jid;
	pid_t pid;
	char* number=argv[1];
	sigset_t mask_all,prev_all;
	sigfillset(&mask_all);

	sigprocmask(SIG_BLOCK,&mask_all,&prev_all);
	struct job_t* thisJob;//本次job
	if(number[0]=='%')	{
		jid=atoi(number+1);//important
		if(getjobjid(jobs, jid)==NULL){
			printf("No such job exists");
			return;			
		}
		thisJob=getjobjid(jobs, jid);
	}
	else {
		pid=atoi(number);
		if(getjobpid(jobs, pid)==NULL){
			printf("No such job exists");
			return;					
		}
		thisJob=getjobpid(jobs, pid);
	}
	pid=(*thisJob).pid; 
	if(!strcmp(argv[0],"bg")){
		printf("[%d] (%d) %s",pid2jid(pid),pid,(*thisJob).cmdline);
		thisJob->state=BG;	
	}
	if(!strcmp(argv[0],"fg")){
		thisJob->state=FG;
		waitfg(pid);
	}
	kill(-pid,SIGCONT);	  
 	sigprocmask(SIG_BLOCK,&mask_all,&prev_all);
	return; 
}

/* 
 * waitfg - Block until process pid is no longer the foreground process
 */
void waitfg(pid_t pid)
{
    sigset_t mask;
    sigemptyset(&mask);
	//sigaddset(&mask,SIGCHLD);
    // 设定不阻塞任何信号
    // 其实可以直接sleep显式等待信号
	//printf("等待前台信号中\n");
    while (fgpid(jobs) > 0)
    	sigsuspend(&mask);
    return;
}

/*****************
 * Signal handlers
 *****************/

/* 
 * sigchld_handler - The kernel sends a SIGCHLD to the shell whenever
 *     a child job terminates (becomes a zombie), or stops because it
 *     received a SIGSTOP or SIGTSTP signal. The handler reaps all
 *     available zombie children, but doesn't wait for any other
 *     currently running children to terminate.  
 */
void sigchld_handler(int sig) 
{
	//printf("触发sigchld\n");
	int oldererrno = errno;
	int status;
	sigset_t mask_all,prev_all;
	pid_t pid;

	sigfillset(&mask_all);
	sigprocmask(SIG_BLOCK,&mask_all,&prev_all);
	while((pid=waitpid(-1,&status,WNOHANG|WUNTRACED))>0){
		if(WIFEXITED(status)){
			deletejob(jobs,pid);
		}
		else if(WIFSIGNALED(status)){
			printf("Job [%d] (%d) terminated by signal %d \n",pid2jid(pid),pid,SIGINT);			
			deletejob(jobs,pid);
		}
		else{
			struct job_t* thisJob=getjobpid(jobs, pid);
			printf("Job [%d] (%d) stopped by signal %d \n",pid2jid(pid),pid,SIGTSTP);
			thisJob->state=ST;			
		}
		//printf("sig %d 已经死了\n",pid);
	}
	sigprocmask(SIG_BLOCK,&prev_all,NULL);	
	errno = oldererrno;
    return;
}

/* 
 * sigint_handler - The kernel sends a SIGINT to the shell whenver the
 *    user types ctrl-c at the keyboard.  Catch it and send it along
 *    to the foreground job.  
 */
void sigint_handler(int sig) 
{
	int oldererrno = errno;	
	pid_t pid=fgpid(jobs);
	if(pid==0) {
		printf("No foreground job is running now");
		return;// 没有fg job
	}
	kill(-pid,SIGINT);//向fg job的进程组发送信号
	errno = oldererrno;
    return;
}

/*
 * sigtstp_handler - The kernel sends a SIGTSTP to the shell whenever
 *     the user types ctrl-z at the keyboard. Catch it and suspend the
 *     foreground job by sending it a SIGTSTP.  
 */
void sigtstp_handler(int sig) 
{
	int oldererrno = errno;
	pid_t pid=fgpid(jobs);
	if(pid==0) {
		printf("No foreground job is running now");
		return;// 没有fg job
	}
	kill(-pid,SIGTSTP);//向fg job的进程组发送信号
	errno = oldererrno;
    return;
}

/*********************
 * End signal handlers
 *********************/

/***********************************************
 * Helper routines that manipulate the job list
 **********************************************/

/* clearjob - Clear the entries in a job struct */
void clearjob(struct job_t *job) {
    job->pid = 0;
    job->jid = 0;
    job->state = UNDEF;
    job->cmdline[0] = '\0';
}

/* initjobs - Initialize the job list */
void initjobs(struct job_t *jobs) {
    int i;

    for (i = 0; i < MAXJOBS; i++)
	clearjob(&jobs[i]);
}

/* maxjid - Returns largest allocated job ID */
int maxjid(struct job_t *jobs) 
{
    int i, max=0;

    for (i = 0; i < MAXJOBS; i++)
	if (jobs[i].jid > max)
	    max = jobs[i].jid;
    return max;
}

/* addjob - Add a job to the job list */
int addjob(struct job_t *jobs, pid_t pid, int state, char *cmdline) 
{
    int i;
    
    if (pid < 1)
	return 0;

    for (i = 0; i < MAXJOBS; i++) {
		if (jobs[i].pid == 0) {
			jobs[i].pid = pid;
			jobs[i].state = state;
			jobs[i].jid = nextjid++;
			if (nextjid > MAXJOBS)
				nextjid = 1;
			strcpy(jobs[i].cmdline, cmdline);
	  	    if(verbose){
			    printf("Added job [%d] %d %s\n", jobs[i].jid, jobs[i].pid, jobs[i].cmdline);
		    }
		    return 1;
		}
    }
    printf("Tried to create too many jobs\n");
    return 0;
}

/* deletejob - Delete a job whose PID=pid from the job list */
int deletejob(struct job_t *jobs, pid_t pid) 
{
    int i;

    if (pid < 1)
	return 0;

    for (i = 0; i < MAXJOBS; i++) {
	if (jobs[i].pid == pid) {
	    clearjob(&jobs[i]);
	    nextjid = maxjid(jobs)+1;
	    return 1;
	}
    }
    return 0;
}

/* fgpid - Return PID of current foreground job, 0 if no such job */
pid_t fgpid(struct job_t *jobs) {
    int i;

    for (i = 0; i < MAXJOBS; i++)
	if (jobs[i].state == FG)
	    return jobs[i].pid;
    return 0;
}

/* getjobpid  - Find a job (by PID) on the job list */
struct job_t *getjobpid(struct job_t *jobs, pid_t pid) {
    int i;

    if (pid < 1)
	return NULL;
    for (i = 0; i < MAXJOBS; i++)
	if (jobs[i].pid == pid)
	    return &jobs[i];
    return NULL;
}

/* getjobjid  - Find a job (by JID) on the job list */
struct job_t *getjobjid(struct job_t *jobs, int jid) 
{
    int i;

    if (jid < 1)
	return NULL;
    for (i = 0; i < MAXJOBS; i++)
	if (jobs[i].jid == jid)
	    return &jobs[i];
    return NULL;
}

/* pid2jid - Map process ID to job ID */
int pid2jid(pid_t pid) 
{
    int i;

    if (pid < 1)
	return 0;
    for (i = 0; i < MAXJOBS; i++)
	if (jobs[i].pid == pid) {
            return jobs[i].jid;
        }
    return 0;
}

/* listjobs - Print the job list */
void listjobs(struct job_t *jobs) 
{
    int i;
    
    for (i = 0; i < MAXJOBS; i++) {
	if (jobs[i].pid != 0) {
	    printf("[%d] (%d) ", jobs[i].jid, jobs[i].pid);
	    switch (jobs[i].state) {
		case BG: 
		    printf("Running ");
		    break;
		case FG: 
		    printf("Foreground ");
		    break;
		case ST: 
		    printf("Stopped ");
		    break;
	    default:
		    printf("listjobs: Internal error: job[%d].state=%d ", 
			   i, jobs[i].state);
	    }
	    printf("%s", jobs[i].cmdline);
	}
    }
}
/******************************
 * end job list helper routines
 ******************************/


/***********************
 * Other helper routines
 ***********************/

/*
 * usage - print a help message
 */
void usage(void) 
{
    printf("Usage: shell [-hvp]\n");
    printf("   -h   print this message\n");
    printf("   -v   print additional diagnostic information\n");
    printf("   -p   do not emit a command prompt\n");
    exit(1);
}

/*
 * unix_error - unix-style error routine
 */
void unix_error(char *msg)
{
    fprintf(stdout, "%s: %s\n", msg, strerror(errno));
    exit(1);
}

/*
 * app_error - application-style error routine
 */
void app_error(char *msg)
{
    fprintf(stdout, "%s\n", msg);
    exit(1);
}

/*
 * Signal - wrapper for the sigaction function
 */
handler_t *Signal(int signum, handler_t *handler) 
{
    struct sigaction action, old_action;

    action.sa_handler = handler;  
    sigemptyset(&action.sa_mask); /* block sigs of type being handled */
    action.sa_flags = SA_RESTART; /* restart syscalls if possible */

    if (sigaction(signum, &action, &old_action) < 0)
	unix_error("Signal error");
    return (old_action.sa_handler);
}

/*
 * sigquit_handler - The driver program can gracefully terminate the
 *    child shell by sending it a SIGQUIT signal.
 */
void sigquit_handler(int sig) 
{
    printf("Terminating after receipt of SIGQUIT signal\n");
    exit(1);
}