Enusre Chained Methods are thread-safe

https://www.securecoding.cert.org/confluence/display/java/VNA04-J.+Ensure+that+calls+to+chained+methods+are+atomic
在上面这篇讲Java安全代码的文章中提到两段代码。第一不是线程安全的;第二个是。
final class USCurrency {
  // Change requested, denomination (optional fields)
  private int quarters = 0;
  private int dimes = 0;
  private int nickels = 0;
  private int pennies = 0;

  public USCurrency() {}

  // Setter methods
  public USCurrency setQuarters(int quantity) {
    quarters = quantity;
    return this;
  }
  public USCurrency setDimes(int quantity) {
  dimes = quantity;
    return this;
  }
  public USCurrency setNickels(int quantity) {
    nickels = quantity;
    return this;
  }
  public USCurrency setPennies(int quantity) {
    pennies = quantity;
    return this;
  }
}

// Client code:
class ExampleClientCode {
  private final USCurrency currency = new USCurrency();
  // ...
  public ExampleClientCode() {

  Thread t1 = new Thread(new Runnable() {
        @Override public void run() {
        currency.setQuarters(1).setDimes(1);
        }
  });
  t1.start();

  Thread t2 = new Thread(new Runnable() {
        @Override public void run() {
          currency.setQuarters(2).setDimes(2);
        }
    });
    t2.start();
  }
}



final class USCurrency {
  private final int quarters;
  private final int dimes;
  private final int nickels;
  private final int pennies;

  public USCurrency(Builder builder) {
    this.quarters = builder.quarters;
    this.dimes = builder.dimes;
    this.nickels = builder.nickels;
    this.pennies = builder.pennies;
  }

  // Static class member
  public static class Builder {
    private int quarters = 0;
    private int dimes = 0;
    private int nickels = 0;
    private int pennies = 0;
    public static Builder newInstance() {
      return new Builder();
    }

    private Builder() {}

    // Setter methods
    public Builder setQuarters(int quantity) {
      this.quarters = quantity;
      return this;
    }
    public Builder setDimes(int quantity) {
      this.dimes = quantity;
      return this;
    }
    public Builder setNickels(int quantity) {
      this.nickels = quantity;
      return this;
    }
    public Builder setPennies(int quantity) {
      this.pennies = quantity;
    return this;
    }

    public USCurrency build() {
      return new USCurrency(this);
    }
  }
}

// Client code:
class ExampleClientCode? {

  private volatile USCurrency currency;
  // ...

  public ExampleClientCode() {

    Thread t1 = new Thread(new Runnable() {
      @Override public void run() {
        currency = USCurrency.Builder.newInstance().
                    setQuarters(1).setDimes(1).build();
        }
    });
    t1.start();

    Thread t2 = new Thread(new Runnable() {
        @Override public void run() {
           currency = USCurrency.Builder.newInstance().
                   setQuarters(2).setDimes(2).build();
    }
    });
    t2.start();

//...
}
}

第二个在<<Effective Java 2nd>>中提到,是Item2。我理解第二个所以是线程安全是因为两个线程构建了两个不同的对象,也就是两个线程没有访问同一个对象。对第一个程序做类似的处理也能达到线程安全的目的。

final class USCurrency {
  // Change requested, denomination (optional fields)
  private int quarters = 0;
  private int dimes = 0;
  private int nickels = 0;
  private int pennies = 0;

  public USCurrency() {}

  // Setter methods
  public USCurrency setQuarters(int quantity) {
    quarters = quantity;
    return this;
  }
  public USCurrency setDimes(int quantity) {
  dimes = quantity;
    return this;
  }
  public USCurrency setNickels(int quantity) {
    nickels = quantity;
    return this;
  }
  public USCurrency setPennies(int quantity) {
    pennies = quantity;
    return this;
  }
}

// Client code:
class ExampleClientCode {
  private final USCurrency currency;
  // ...
  public ExampleClientCode() {

  Thread t1 = new Thread(new Runnable() {
        @Override public void run() {
          USCurrency temp = new USCurrency();
          temp.setQuarters(1).setDimes(1);
          currency = temp;
        }
  });
  t1.start();

  Thread t2 = new Thread(new Runnable() {
        @Override public void run() {
          USCurrency temp = new USCurrency();
          temp.setQuarters(2).setDimes(2);
          currency = temp;
        }
    });
    t2.start();
  }
}
  • 0
    点赞
  • 0
    收藏
    觉得还不错? 一键收藏
  • 0
    评论

“相关推荐”对你有帮助么?

  • 非常没帮助
  • 没帮助
  • 一般
  • 有帮助
  • 非常有帮助
提交
评论
添加红包

请填写红包祝福语或标题

红包个数最小为10个

红包金额最低5元

当前余额3.43前往充值 >
需支付:10.00
成就一亿技术人!
领取后你会自动成为博主和红包主的粉丝 规则
hope_wisdom
发出的红包
实付
使用余额支付
点击重新获取
扫码支付
钱包余额 0

抵扣说明:

1.余额是钱包充值的虚拟货币,按照1:1的比例进行支付金额的抵扣。
2.余额无法直接购买下载,可以购买VIP、付费专栏及课程。

余额充值