对《JCP》"3.4.2"的理解

This chapter explain publishing immutable objects using "Volatile".
The example codes are 
class OneValueCache {
    private final BigInteger lastNumer;
    private final BigInterger[] lastFactors;

    public OneValueCahche(BigInterger i, BigInteger[] factors){
        lastNumber  = i;
        lastFactors = factors; 
    }

    public BigInteger[] getFactors(BigInteger i){
        if(lastNumber == null || !lastNumber.equals(i)){
            return null;
        }else{
            return Arrays.copyOf(lastFactors,lastFactors.length);
        }
    }
}

public class VolatileCachedFactorizer implements Servlet {
    private volatile OneValueCache cache = new OneValueCache(null,null);
    public void service(ServletRequest req, ServletResponse resp){
        BigInteger i = extractFromRequest(req);
        BigInteger [] factors = cache.getFactors(i);
        if(factors == null){
            factors = factor(i);
            cache = new OneValueCache(i,factors);
        }
    }
    encodeIntoResponse(resp,factors);
}

The explanation why it is safety is the following.
The cache-related operations cannot interfere with each other because One-ValueCache is immutable and
the cache field is accessed only once in each of the relevant code paths. 

I try to understand "the cache field is accessed only once in each of the relevant code paths".
Change the codes. See the next. The class "VolatileCachedFactorizer" is not safety again.

class OneValueCache {
    private final BigInteger lastNumber;
    private final BigInterger[] lastFactors;

    public OneValueCahche(BigInterger i, BigInteger[] factors){
        lastNumber  = i;
        lastFactors = factors;  
    }

    public BigInteger[] getFactors(){
        //if(lastNumber == null || !lastNumber.equals(i)){
         if(lastNumber == null){
            return null;
        }else{
            return Arrays.copyOf(lastFactors,lastFactors.length);
        }
    }

    public boolean isIntegerSame(BigInteger i){
       return (i==lastNumber);
   }
}

public class VolatileCachedFactorizer implements Servlet {
    private volatile OneValueCache cache = new OneValueCache(null,null);
    public void service(ServletRequest req, ServletResponse resp){
        BigInteger i = extractFromRequest(req);
        
        //BigInteger [] factors = cache.getFactors(i);

        // In the code path, "cache" is accessed twice. so it is not thread-safety.
      // The next case is possible. firstly, "cache.isIntegerSame(i)" return true;
      // before executing "cache.getFactors()", another thread update "cache",
      // "lastNumber" and "lastFactors" are changed. Then execute "cache.getFactors()",
      // get a wrong "factors". It is a typical thread-unsafety condition "Check-Then-Act".
         factors = cache.isIntegerSame(i) ? cache.getFactors() : null;
        if(factors == null){
            factors = factor(i);
            cache = new OneValueCache(i,factors);
        }       
    }
    encodeIntoResponse(resp,factors);
}
  • 0
    点赞
  • 0
    收藏
    觉得还不错? 一键收藏
  • 0
    评论

“相关推荐”对你有帮助么?

  • 非常没帮助
  • 没帮助
  • 一般
  • 有帮助
  • 非常有帮助
提交
评论
添加红包

请填写红包祝福语或标题

红包个数最小为10个

红包金额最低5元

当前余额3.43前往充值 >
需支付:10.00
成就一亿技术人!
领取后你会自动成为博主和红包主的粉丝 规则
hope_wisdom
发出的红包
实付
使用余额支付
点击重新获取
扫码支付
钱包余额 0

抵扣说明:

1.余额是钱包充值的虚拟货币,按照1:1的比例进行支付金额的抵扣。
2.余额无法直接购买下载,可以购买VIP、付费专栏及课程。

余额充值