python寻找多数元素,分而治之。查找数组中的大多数元素

I am working on a python algorithm to find the most frequent element in the list.

def GetFrequency(a, element):

return sum([1 for x in a if x == element])

def GetMajorityElement(a):

n = len(a)

if n == 1:

return a[0]

k = n // 2

elemlsub = GetMajorityElement(a[:k])

elemrsub = GetMajorityElement(a[k:])

if elemlsub == elemrsub:

return elemlsub

lcount = GetFrequency(a, elemlsub)

rcount = GetFrequency(a, elemrsub)

if lcount > k:

return elemlsub

elif rcount > k:

return elemrsub

else:

return None

I tried some test cases. Some of them are passed, but some of them fails.

For example, [1,2,1,3,4] this should return 1, buit I get None.

The implementation follows the pseudocode here:

http://users.eecs.northwestern.edu/~dda902/336/hw4-sol.pdf

The pseudocode finds the majority item and needs to be at least half. I only want to find the majority item.

Can I get some help?

Thanks!

解决方案def majority_element(a):

return max([(a.count(elem), elem) for elem in set(a)])[1]

EDIT

If there is a tie, the biggest value is returned. E.g: a = [1,1,2,2] returns 2. Might not be what you want but that could be changed.

EDIT 2

The pseudocode you gave divided into arrays 1 to k included, k + 1 to n. Your code does 1 to k - 1, k to end, not sure if it changes much though ? If you want to respect the algorithm you gave, you should do:

elemlsub = GetMajorityElement(a[:k+1]) # this slice is indices 0 to k

elemrsub = GetMajorityElement(a[k+1:]) # this one is k + 1 to n.

Also still according to your provided pseudocode, lcount and rcount should be compared to k + 1, not k:

if lcount > k + 1:

return elemlsub

elif rcount > k + 1:

return elemrsub

else:

return None

EDIT 3

Some people in the comments highligted that provided pseudocode solves not for the most frequent, but for the item which is present more that 50% of occurences. So indeed your output for your example is correct. There is a good chance that your code already works as is.

EDIT 4

If you want to return None when there is a tie, I suggest this:

def majority_element(a):

n = len(a)

if n == 1:

return a[0]

if n == 0:

return None

sorted_counts = sorted([(a.count(elem), elem) for elem in set(a)], key=lambda x: x[0])

if len(sorted_counts) > 1 and sorted_counts[-1][0] == sorted_counts[-2][0]:

return None

return sorted_counts[-1][1]