分解临时变量:当你的程序有某个临时变量被赋值超过一次,它既不是循环变量,也不被用于收集计算结果。针对每次赋值,创造一个独立、对应的变量。
备注:如果临时变量承担多个责任,它就应该被替换(分解)为多个临时变量,每个临时变量只承担一个责任。
package 第六章;
public class SplitTemporaryVariable {
static double _primaryForce = 1;
static double _mass = 1;
static int _delay = 1;
static double _secondaryForce = 1;
//重构前:
static double getDistaceTravelled(int time) {
double result;
//临时变量acc不仅被赋值一次
double acc = _primaryForce / _mass;
int primaryTime = Math.min(time, _delay);
result = 0.5 * acc * primaryTime * primaryTime;
int secondaryTime = time - _delay;
if(secondaryTime > 0){
double primaryVel = acc * _delay;
acc = (_primaryForce + _secondaryForce) / _mass;
result += primaryVel * secondaryTime + 0.5 * acc * secondaryTime * secondaryTime;
}
return result;
}
//重构后:
static double getDistaceTravelled_(int time) {
double result;
final double primaryAcc = _primaryForce / _mass;
int primaryTime = Math.min(time, _delay);
result = 0.5 * primaryAcc * primaryTime * primaryTime;
int secondaryTime = time - _delay;
if(secondaryTime > 0){
double primaryVel = primaryAcc * _delay;
double secondaryAcc = (_primaryForce + _secondaryForce) / _mass;
result += primaryVel * secondaryTime + 0.5 * secondaryAcc * secondaryTime * secondaryTime;
}
return result;
}
public static void main(String[] args) {
System.out.println("refactor before: "+ getDistaceTravelled(10));
System.out.println("refactor after: "+ getDistaceTravelled_(10));
}
}