问题现象
golang ci检测提示:
S1034: assigning the result of this type assertion to a variable (switch inter := inter.(type)) could eliminate the following type assertions:
问题分析
将某类型断言的结果分配给变量可以消除后续的类型断言,即该变量就变成了类型转换后的结果了,这样就消除了多余的类型转换
问题举例
例如以下未知类型转换为string类型的代码:
func interface2String(inter interface{}) {
switch inter.(type) {
case string:
return inter.(string)
case int:
return string(rune(inter.(string)))
case int64:
return strconv.FormatInt(inter.(int64), 10)
case int32:
return strconv.FormatInt(int64(inter.(int64)), 10)
case float32:
return strconv.FormatFloat(inter.(float64), 'E', -1, 32)
case float64:
return strconv.FormatFloat(inter.(float64), 'E', -1, 64)
default:
return ""
}
}
应该简化为:
func interface2String(inter interface{}) string {
switch inter := inter.(type) {
case string:
return inter
case int:
return string(rune(inter))
case int64:
return strconv.FormatInt(inter, 10)
case int32:
return strconv.FormatInt(int64(inter), 10)
case float32:
return strconv.FormatFloat(float64(inter), 'E', -1, 32)
case float64:
return strconv.FormatFloat(inter, 'E', -1, 64)
default:
return ""
}
}