针对上次的流水号生成有几处细节优化的地方
1、高并发的时候,在哪个位置加锁?
2、加锁的重试机制如何设置?
3、加锁的重试次数与间隔时间范围应该如何?
4、入队列的优化
1、首先获取一次缓存中的序列号,不要直接加分布式锁,毕竟遇到查不到的情况约1000分之一
2、流水号大约1秒多生成,建议超时时长设置为2-3秒,重试次数可以多次,每次间隔500ms即可。间隔过大,会导致撞锁。间隔太小会导致无用的重试次数太多。
3、一次操作时间《加锁的重试次数*间隔时间<两次操作时间。理由是:若重试的次数*间隔时间比一次操作时间短,则会导致加锁失败。若大于两次操作时间,则造成浪费。
4、入队的方式,除了执行一个个命令外,rpush是支持把数组一次性存入缓存的。
附上代码(敏感引入已去除):
import org.apache.commons.lang3.StringUtils;
import org.springframework.stereotype.Service;
import javax.annotation.Resource;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.Random;
import java.util.concurrent.TimeUnit;
/**
* @description:
* @author: wzh
* @date: 2019-01-21 上午10:44
*/
@Service("dubheSerialNumberCenterServiceImpl")
public class DubheSerialNumberCenterServiceImpl implements DubheSerialNumberCenterService {
private static final Logger logger = LoggerFactory.getLogger(DubheSerialNumberCenterServiceImpl.class);
/*超时时间:代码中与TimeUnit.SECONDS共用*/
private static long expireTime = 3;
/*重试次数*/
private static int retryCount = 10;
@Resource
private DubheSerialNumberRuleService dubheSerialNumberRuleService;
@Resource
private DistributedLocker distributedLocker;
@Resource
private R2mClusterClient r2mClusterClient;
@Override
public CommonResponse<String> generateSerialNumber(CommonRequest<SerialNumberRequest> req) {
String methodDesc = "DubheSerialNumberCenterServiceImpl|generateSerialNumber|按规则编码生成流水号|";
SerialNumberRequest serialNumberRequest = req.getRequestData();
String ruleCode = serialNumberRequest.getRuleCode();
StringBuilder crlSerialNumber = new StringBuilder();
logger.info(methodDesc + "查询流水号规则开始" + "|ruleCode:" + ruleCode);
DubheSerialNumberRule dubheSerialNumberRule = dubheSerialNumberRuleService.getSerialNumberRuleByParams(serialNumberRequest.getRuleCode());
if (null == dubheSerialNumberRule) {
logger.warn(methodDesc + "查询流水号规则为空,请检查流水号规则配置" + "|ruleCode:" + ruleCode);
crlSerialNumber.append("ERR").append(new SimpleDateFormat(DateFormatterEnum.yyMMddHHmmss.getCode()).format(new Date())).append(String.valueOf(new Random().nextInt(9))).append(new Random().nextInt(getMaxValueString(8))).toString();
return CommonResponse.buildResponse(req, RespCodeEnum.SERIAL_NO_RULE_NOT_EXIST, crlSerialNumber.toString());
}
logger.info(methodDesc +"查询流水号规则结束" + "|ruleCode:" + ruleCode + "|dubheSerialNumberRule:" + dubheSerialNumberRule);
String dateFormatter = dubheSerialNumberRule.getDateFormatter();
String dateString = "";
if (StringUtils.isNotBlank(dateFormatter)) {
dateString = new SimpleDateFormat(dateFormatter).format(new Date());
}
String randomMark = "";
if (0<dubheSerialNumberRule.getRandomMark()) {
int maxNumber=getMaxValueString(dubheSerialNumberRule.getRandomMark());
randomMark = format(dubheSerialNumberRule.getRandomMark(),new Random().nextInt(maxNumber));
}
int random = new Random().nextInt(getMaxValueS