双重for循环优化

Demo

public class TestFamily {
    @Test
    public void familyTest() {
        List<Wife> wife = Lists.newArrayList();
        List<Husband> husband = Lists.newArrayList();
        for (int i = 0; i < 800; i++) {
            wife.add(new Wife(i,i+"的妻子","000"+i));
        }
        for (int i = 0; i < 800; i++) {
            husband.add(new Husband(i,"我是"+i,"000"+i));
        }
        Long startTime = System.currentTimeMillis();
        System.out.println("当前时间:"+startTime);
        List<Family> families = Lists.newArrayList();
        // 将list转为map，key为唯一值Function.identity()
        Map<Integer,Wife> wifeMap = wife.stream().collect(Collectors.toMap(w -> w.getFamilyId(),w -> w));

        // 匹配家庭
        families = husband.stream().map(h -> {
            return toFamily(wifeMap.get(h.getFamilyId()),h);
        }).collect(Collectors.toList());

        System.out.println("循环完成");
        families.stream().forEach(family -> {
            System.out.println("家庭ID:" + family.getFamilyId() + ",丈夫:" + family.getHusbandName() + ",妻子:" + family.getWifeName());
        });
        Long endTime = System.currentTimeMillis();
        System.out.println("结束时间:" + endTime);
        System.out.println("--------耗时:--------"+(endTime-startTime)+"ms");
    }

    private Family toFamily(Wife wife,Husband husband) {
        Family family = new Family();
        family.setFamilyId(wife.getFamilyId());
        family.setHusbandName(family.getHusbandName());
        family.setWifeName(family.getWifeName());
        return family;
    }
}

class Wife {
    public Integer getFamilyId() {
        return familyId;
    }
    public void setFamilyId(Integer familyId) {
        this.familyId = familyId;
    }
    private Integer familyId;
    private String name;
    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
    }
    public String getName1() {
        return name1;
    }
    public void setName1(String name1) {
        this.name1 = name1;
    }
    private String name1;
    public Wife(Integer familyId,String name,String name1) {
        this.familyId = familyId;
        this.name = name;
        this.name1 = name1;
    }
    public Wife() {

    }
}

class Husband {
    public Integer getFamilyId() {
        return familyId;
    }
    public void setFamilyId(Integer familyId) {
        this.familyId = familyId;
    }
    private Integer familyId;
    private String name;
    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
    }
    public String getName1() {
        return name1;
    }
    public void setName1(String name1) {
        this.name1 = name1;
    }
    private String name1;
    public Husband(Integer familyId,String name,String name1) {
        this.familyId = familyId;
        this.name = name;
        this.name1 = name1;
    }
    public Husband () {

    }
}

class Family {
    private Integer familyId;
    public String getHusbandName() {
        return husbandName;
    }
    public void setHusbandName(String husbandName) {
        this.husbandName = husbandName;
    }
    public String getWifeName() {
        return wifeName;
    }
    public void setWifeName(String wifeName) {
        this.wifeName = wifeName;
    }
    private String husbandName;
    public Family() {

    }
    public Integer getFamilyId() {
        return familyId;
    }
    public void setFamilyId(Integer familyId) {
        this.familyId = familyId;
    }
    private String wifeName;

    public Family(Integer familyId,String husbandName,String wifeName) {
        this.familyId = familyId;
        this.husbandName = husbandName;
        this.wifeName = wifeName;
    }
}

项目实践：

原代码：

        List<BillCoinTypeUserProperty> fenList = new ArrayList<>();
        for (BillCoinTypeUserProperty end : endList) {
            for (BillCoinTypeUserProperty begin : beginList) {
                if (begin.getUserId().equals(end.getUserId()) && begin.getCoinId().equals(end.getCoinId()) && begin.getBizType().equals(end.getBizType())) {
                    BillCoinTypeUserProperty billCoinTypeUserProperty = new BillCoinTypeUserProperty();
                    billCoinTypeUserProperty.setBizType(begin.getBizType());
                    billCoinTypeUserProperty.setCoinId(begin.getCoinId());
                    billCoinTypeUserProperty.setUserId(begin.getUserId());
                    billCoinTypeUserProperty.setProp1(end.getProp1().subtract(begin.getProp1()));
                    billCoinTypeUserProperty.setProp2(end.getProp2().subtract(begin.getProp2()));
                    billCoinTypeUserProperty.setProp3(end.getProp3().subtract(begin.getProp3()));
                    billCoinTypeUserProperty.setProp4(end.getProp4().subtract(begin.getProp4()));
                    billCoinTypeUserProperty.setProp5(end.getProp5().subtract(begin.getProp5()));
                    list.add(billCoinTypeUserProperty);
                    fenList.add(end);
                }
            }
        }
        endList.removeAll(fenList);
        list.addAll(endList);
 return list;
        // 根据userId + coinId + bizType去查询相同

优化后代码：

private List<BillCoinTypeUserProperty> selectTimeDifference(List<BillCoinTypeUserProperty> beginList, List<BillCoinTypeUserProperty> endList) {
    // 基于两个时间点做差
    List<BillCoinTypeUserProperty> list = new ArrayList<>();
    Map<String, BillCoinTypeUserProperty> map = new HashMap<>();
    Map<String, BillCoinTypeUserProperty> beginMap = beginList.stream().collect(Collectors.toMap(k -> k.getUserId().toString() + k.getCoinId().toString() + k.getBizType(), Function.identity()));
    Map<String, BillCoinTypeUserProperty> endMap = endList.stream().collect(Collectors.toMap(k -> k.getUserId().toString() + k.getCoinId().toString() + k.getBizType(), Function.identity()));
    for (Map.Entry<String, BillCoinTypeUserProperty> entry : endMap.entrySet()) {
        String key = entry.getKey();
        BillCoinTypeUserProperty endProperty = entry.getValue();
        BillCoinTypeUserProperty beginProperty = beginMap.get(key);
        if (Objects.isNull(beginProperty)) {
            map.put(key, endProperty);
        } else {
            BillCoinTypeUserProperty billCoinTypeUserProperty = new BillCoinTypeUserProperty();
            billCoinTypeUserProperty.setUserId(endProperty.getUserId());
            billCoinTypeUserProperty.setCoinId(endProperty.getCoinId());
            billCoinTypeUserProperty.setBizType(endProperty.getBizType());
            billCoinTypeUserProperty.setProp1(endProperty.getProp1().subtract(beginProperty.getProp1()));
            billCoinTypeUserProperty.setProp2(endProperty.getProp2().subtract(beginProperty.getProp2()));
            billCoinTypeUserProperty.setProp3(endProperty.getProp3().subtract(beginProperty.getProp3()));
            billCoinTypeUserProperty.setProp4(endProperty.getProp4().subtract(beginProperty.getProp4()));
            billCoinTypeUserProperty.setProp5(endProperty.getProp5().subtract(beginProperty.getProp5()));
            map.put(key, billCoinTypeUserProperty);
        }
    }
    List<BillCoinTypeUserProperty> billCoinTypeUserPropertyList = new ArrayList<>(map.values());
    list.addAll(billCoinTypeUserPropertyList);
    return list;
}