C语言的那些坑(C Primer Plus第六版 17.2程序释放链表bug)

第三个坑 C Primer Plus第六版 17.2程序释放链表bug
C Primer Plus是一本很好的C语言书,里面的代码丰富详细,对初学者的晋升有很大帮助,但问题在于代码也都是人编写的,出现bug也是很正常的。善于发现bug也是一种能力。

话不多说 实锤
下面是书中的源代码

#include <stdio.h>
#include <stdlib.h>      /* has the malloc prototype      */
#include <string.h>      /* has the strcpy prototype      */
#define TSIZE    45      /* size of array to hold title   */

struct film {
    char title[TSIZE];
    int rating;
    struct film * next;  /* points to next struct in list */
};
char * s_gets(char * st, int n);
int main(void)
{
    struct film * head = NULL;
    struct film * prev, * current;
    char input[TSIZE];

    /* Gather  and store information          */
    puts("Enter first movie title:");
    while (s_gets(input, TSIZE) != NULL && input[0] != '\0')
    {
        current = (struct film *) malloc(sizeof(struct film));
        if (head == NULL)       /* first structure       */
            head = current;
        else                    /* subsequent structures */
            prev->next = current;
        current->next = NULL;
        strcpy(current->title, input);
        puts("Enter your rating <0-10>:");
        scanf("%d", &current->rating);
        while(getchar() != '\n')
            continue;
        puts("Enter next movie title (empty line to stop):");
        prev = current;
    }

    /* Show list of movies                    */
    if (head == NULL)
        printf("No data entered. ");
    else
        printf ("Here is the movie list:\n");
    current = head;
    while (current != NULL)
    {
        printf("Movie: %s  Rating: %d\n",
               current->title, current->rating);
        current = current->next;
    }

    /* Program done, so free allocated memory */
    current = head;
    while (current != NULL)
    {
        free(current);
        current = current->next;
    }
    printf("Bye!\n");

    return 0;
}

char * s_gets(char * st, int n)
{
    char * ret_val;
    char * find;

    ret_val = fgets(st, n, stdin);
    if (ret_val)
    {
        find = strchr(st, '\n');   // look for newline
        if (find)                  // if the address is not NULL,
            *find = '\0';          // place a null character there
        else
            while (getchar() != '\n')
                continue;          // dispose of rest of line
    }
    return ret_val;
}

这是一段典型的尾插法创建链表然后并对其遍历的代码。问题出现在主函数最后部分释放链表的时候。

    /* Program done, so free allocated memory */
    current = head;
    while (current != NULL)
    {
        free(current);
        current = current->next;
    }

将current指向了表头,然后依次释放直到next指针为null为止。但当代码执行后会发现这里会报错,问题在于,先free了current,那么current->next的值自然也跟随释放了,此时current->next不再指向下一结点。所以current = current->next也就没有了意义。
所以此处正确的做法是创建一个临时变量,在释放current之前将它的下一结点保存下来。如下:

    while (current != NULL)
    {
        struct film * tmp = current->next;
        free(current);
        current = tmp;
    }
已标记关键词 清除标记
©️2020 CSDN 皮肤主题: 编程工作室 设计师:CSDN官方博客 返回首页