我们使用stop终止线程会出现的问题
public class User {
private int id;
private String name;
public User() {
id=0;
name="0";
}
public int getId() {
return id;
}
public void setId(int id) {
this.id = id;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
@Override
public String toString() {
return "User [id=" + id + ", name=" + name + "]";
}
}
public class StopThreadUnsafe {
public static User u = new User();
public static class ChangeObjectThread extends Thread {
@Override
public void run() {
while (true) {
synchronized (u) {
int v = (int) (System.currentTimeMillis() / 1000);
u.setId(v);
System.out.println("do sth");
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
e.printStackTrace();
}
u.setName(String.valueOf(v));
}
Thread.yield();
}
}
}
public static class ReadObjectThread extends Thread {
@Override
public void run() {
while (true) {
synchronized (u) {
if (u.getId() != Integer.parseInt(u.getName())) {
System.out.println(u.toString());
}
}
Thread.yield();
}
}
}
public static void main(String[] args) throws InterruptedException {
new ReadObjectThread().start();
while (true) {
Thread t = new ChangeObjectThread();
t.start();
Thread.sleep(1000);
t.stop();
}
}
}
产生id与name不同:
User [id=1498129300, name=1498129299]
User [id=1498129297, name=1498129294]
User [id=1498129295, name=1498129294]
解析:
当写线程写对象,读对象无法获得锁,因此等待,所以读线程看不见一个写了一半的对象。当写线程写完id,很不幸被stop(),
此时对象id=1,而name=0,处于不一致状态。而被终止的写线程简单的释放锁,读线程争夺锁后,读取数据,于是出现id与name不相等的情况。
那么不用stop如何停止一个线程?
我们自行决定线程何时退出就行了。
改进:
public static class ChangeObjectThread extends Thread {
volatile boolean stopme = false;
public void stopMe() {
stopme = true;
}
@Override
public void run() {
while (true) {
if (stopme) {
System.out.println("stopme stop!");
break;
}
synchronized (u) {
int v = (int) (System.currentTimeMillis() / 1000);
u.setId(v);
System.out.println("do sth");
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
e.printStackTrace();
}
u.setName(String.valueOf(v));
}
Thread.yield();
}
}
}
不会出现u的状态错误了。
do sth
stopme stop!
User [id=1498130854, name=1498130854]
每天努力一点,每天都在进步!