1. 问题背景
一个支付交易的项目,有个退款订单查询的功能。支付实际对接两个渠道,一个网联,一个银联。
客户测试退款查询时,发现有的报【系统异常】,有的查询正常。查询后台日志,发现报【系统异常】的订单,实际的异常是堆栈溢出。顿时感觉有点奇怪,不常见。
系统异常:Handler dispatch failed; nested exception is java.lang.StackOverflowError
org.springframework.web.util.NestedServletException: Handler dispatch failed; nested exception is java.lang.StackOverflowError
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1058)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:943)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:909)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at brave.servlet.TracingFilter.doFilter(TracingFilter.java:65)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at com.pab.cloudpay.foundation.web.filter.XssFilter.doFilter(XssFilter.java:25)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.springframework.cloud.sleuth.instrument.web.ExceptionLoggingFilter.doFilter(ExceptionLoggingFilter.java:50)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at brave.servlet.TracingFilter.doFilter(TracingFilter.java:82)
at org.springframework.cloud.sleuth.instrument.web.LazyTracingFilter.doFilter(TraceWebServletAutoConfiguration.java:138)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:109)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.unidal.cat.CatFilter$Context.handle(CatFilter.java:438)
at org.unidal.cat.CatFilter$CatHandler$4.handle(CatFilter.java:307)
at org.unidal.cat.CatFilter$Context.handle(CatFilter.java:436)
at org.unidal.cat.CatFilter$CatHandler$3.handle(CatFilter.java:249)
at org.unidal.cat.CatFilter$Context.handle(CatFilter.java:436)
at org.unidal.cat.CatFilter$CatHandler$2.handle(CatFilter.java:209)
at org.unidal.cat.CatFilter$Context.handle(CatFilter.java:436)
at org.unidal.cat.CatFilter$CatHandler$1.handle(CatFilter.java:141)
at org.unidal.cat.CatFilter$Context.handle(CatFilter.java:436)
at org.unidal.cat.CatFilter.doFilter(CatFilter.java:43)
at org.unidal.cat.CatFilter.doFilter(CatFilter.java:48)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:541)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:367)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1639)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.StackOverflowError: null
at java.lang.Throwable$PrintStreamOrWriter.<init>(Throwable.java:729)
at java.lang.Throwable$PrintStreamOrWriter.<init>(Throwable.java:729)
at java.lang.Throwable$WrappedPrintStream.<init>(Throwable.java:740)
at java.lang.Throwable.printStackTrace(Throwable.java:644)
at java.lang.Throwable.printStackTrace(Throwable.java:635)
at com.ping.qa.libra.implant.Implant.recordMethodCoverLine(Implant.java:44)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:69)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
at com.pab.cloudpay.trade.services.service.barcode.union.OrderPayB2BService.channelRefundQuery(OrderPayB2BService.java:68)
2. 问题分析
- 先看报错代码的相关结构
/**
* 订单支付service类
*/
@Slf4j
@Component(value = "unionOrderPayB2BService")
public class UnionOrderPayB2BService extends OrderPayB2BService {
@Autowired
private CncpsOrderPayApi cncpsOrderPayApi;
public void channelOrderQuery(ChannelQueryVO channelQueryVo){
}
}
@Component(value = "orderPayB2BService")
public class OrderPayB2BService extends PayServiceAbstract {
@Resource
private ChannelServiceFactory channelServiceFactory;
@Override
public void channelRefundQuery(ChannelRefundQueryVO channelRefundQueryVO) throws Exception {
channelServiceFactory.getServiceByRealChannelCode(channelRefundQueryVO.getOrder().getRealChannelCode())
.channelRefundQuery(channelRefundQueryVO);
}
}
@Slf4j
@Service
public abstract class PayServiceAbstract implements PayService {
/**
* 调用通道服务退款订单查询接口,每个支付方式自己实现
*
* @param vo
* @return
*/
public abstract void channelRefundQuery(ChannelRefundQueryVO vo) throws Exception;
}
@Component
public class ChannelServiceFactory {
@Resource
private ApplicationContext applicationContext;
public PayServiceAbstract getServiceByRealChannelCode(String realChannelCode) {
if (Objects.equals(Channel.NUCC.getCode(), realChannelCode)) {
return applicationContext.getBean(NuccEbankPayService.class);
}
if (Objects.equals(Channel.ORDER_PAY_UP.getCode(), realChannelCode)) {
return applicationContext.getBean(UnionOrderPayB2BService.class);
}
throw new BizException(ErrorCodeEnum.REAL_CHANNEL_CODE_IS_NOT_VALID);
}
}
@Component
public class PayServiceFactory {
@Resource
private ApplicationContext applicationContext;
public PayServiceAbstract getService(String payWay) {
if (Objects.equals(PayWay.OrderPayB2B.getCode(), payWay)) {
return (OrderPayB2BService) applicationContext.getBean("orderPayB2BService");
}
}
}
- 代码入口,是根据退款的支付类型,通过【PayServiceAbstract.getService()】进入到了【OrderPayB2BService.channelRefundQuery()】,
然后根据【realChannelCode】,在【ChannelServiceFactory.getServiceByRealChannelCode()】得到【UnionOrderPayB2BService.class】,
但是【UnionOrderPayB2BService.class】里面,并没有对抽象方法【channelRefundQuery()】的实现。
那这个时候,程序应该会继续去找【UnionOrderPayB2BService】的父类【OrderPayB2BService】,看有没有具体实现,然后就进入【OrderPayB2BService.channelRefundQuery()】
然后这里面又又又定位到【UnionOrderPayB2BService.class】的实现,就一直这样循环,不知道这个算不算递归。
看起来,应该就是没有实现的问题。通过GIT查询代码提交历史,发现有人重构了。但是重构的有问题,把原来的逻辑搞没了。
3. 改进措施
-
第一步,是开发人员对修改的内容,没有充分的自测,单元测试没有覆盖到。
-
没有跟测试同事说清楚测试范围,实际需要验证两个渠道的退款查询。走另一个渠道是正常的。估计是漏了。