一、老师代码
漏接一个节点已修复,但更改了测试用例,发现小bug.
#include <stdio.h>
#include <malloc.h>
/**
* Linked list of integers. The key is data. The key is sorted in non-descending order.
*/
typedef struct LinkNode{
int coefficient;
int exponent;
struct LinkNode *next;
} *LinkList, *NodePtr;
/**
* Initialize the list with a header.
* @return The pointer to the header.
*/
LinkList initLinkList(){
LinkList tempHeader = (LinkList)malloc(sizeof(struct LinkNode));
tempHeader->coefficient = 0;
tempHeader->exponent = 0;
tempHeader->next = NULL;
return tempHeader;
}// Of initLinkList
/**
* Print the list.
* @param paraHeader The header of the list.
*/
void printList(LinkList paraHeader){
NodePtr p = paraHeader->next;
while (p != NULL) {
printf("%d * 10^%d + ", p->coefficient, p->exponent);
p = p->next;
}// Of while
printf("\r\n");
}// Of printList
/**
* Print one node for testing.
* @param paraPtr The pointer to the node.
* @param paraChar The name of the node.
*/
void printNode(NodePtr paraPtr, char paraChar){
if (paraPtr == NULL) {
printf("NULL\r\n");
} else {
printf("The element of %c is (%d * 10^%d)\r\n", paraChar, paraPtr->coefficient, paraPtr->exponent);
}// Of while
}// Of printNode
/**
* Add an element to the tail.
* @param paraCoefficient The coefficient of the new element.
* @param paraExponent The exponent of the new element.
*/
void appendElement(LinkList paraHeader, int paraCoefficient, int paraExponent){
NodePtr p, q;
// Step 1. Construct a new node.
q = (NodePtr)malloc(sizeof(struct LinkNode));
q->coefficient = paraCoefficient;
q->exponent = paraExponent;
q->next = NULL;
// Step 2. Search to the tail.
p = paraHeader;
while (p->next != NULL) {
p = p->next;
}// Of while
// Step 3. Now add/link.
p->next = q;
}// Of appendElement
/**
* Polynomial addition.
* @param paraList1 The first list.
* @param paraList2 The second list.
*/
void add(NodePtr paraList1, NodePtr paraList2){
NodePtr p, q, r, s;
// Step 1. Search to the position.
p = paraList1->next;
printNode(p, 'p');
q = paraList2->next;
printNode(q, 'q');
r = paraList1; // Previous pointer for inserting.
printNode(r, 'r');
free(paraList2); // The second list is destroyed.
while ((p != NULL) && (q != NULL)) {
if (p->exponent < q->exponent) {
//Link the current node of the first list.
printf("case 1\r\n");
r->next=p;
r = p;
printNode(r, 'r');
p = p->next;
printNode(p, 'p');
} else if ((p->exponent > q->exponent)) {
//Link the current node of the second list.
printf("case 2\r\n");
r->next = q;
r = q;
printNode(r, 'r');
q = q->next;
printNode(q, 'q');
} else {
printf("case 3\r\n");
//Change the current node of the first list.
p->coefficient = p->coefficient + q->coefficient;
printf("The coefficient is: %d.\r\n", p->coefficient);
if (p->coefficient == 0) {
printf("case 3.1\r\n");
s = p;
p = p->next;
printNode(p, 'p');
// free(s);
} else {
printf("case 3.2\r\n");
r = p;
printNode(r, 'r');
p = p->next;
printNode(p, 'p');
}// Of if
s = q;
q = q->next;
//printf("q is pointing to (%d, %d)\r\n", q->coefficient, q->exponent);
free(s);
}// Of if
printf("p = %ld, q = %ld \r\n", p, q);
} // Of while
printf("End of while.\r\n");
if (p == NULL) {
r->next = q;
} else {
r->next = p;
} // Of if
printf("Addition ends.\r\n");
}// Of add
/**
* Unit test.
*/
void additionTest(){
// Step 1. Initialize the first polynomial.
LinkList tempList1 = initLinkList();
appendElement(tempList1, 7, 0);
appendElement(tempList1, 3, 17);
appendElement(tempList1, 9, 8);
appendElement(tempList1, 5, 5);
printList(tempList1);
// Step 2. Initialize the second polynomial.
LinkList tempList2 = initLinkList();
appendElement(tempList2, 8, 1);
appendElement(tempList2, 22, 7);
appendElement(tempList2, -9, 8);
printList(tempList2);
// Step 3. Add them to the first.
add(tempList1, tempList2);
printList(tempList1);
}// Of additionTest
/**
* The entrance.
*/
void main(){
additionTest();
printf("Finish.\r\n");
}// Of main
运行结果:
7 * 10^0 + 3 * 10^17 + 9 * 10^8 + 5 * 10^5 +
8 * 10^1 + 22 * 10^7 + -9 * 10^8 +
The element of p is (7 * 10^0)
The element of q is (8 * 10^1)
The element of r is (0 * 10^0)
case 1
The element of r is (7 * 10^0)
The element of p is (3 * 10^17)
p = 529408, q = 552384
case 2
The element of r is (8 * 10^1)
The element of q is (22 * 10^7)
p = 529408, q = 552416
case 2
The element of r is (22 * 10^7)
The element of q is (-9 * 10^8)
p = 529408, q = 552448
case 2
The element of r is (-9 * 10^8)
NULL
p = 529408, q = 0
End of while.
Addition ends.
7 * 10^0 + 8 * 10^1 + 22 * 10^7 + -9 * 10^8 + 3 * 10^17 + 9 * 10^8 + 5 * 10^5 +
Finish.
当测试用例更改后,可以发现结果中有同类项并未合并。根据自己想法,将每个链表进行排序后,再来相加。
二、更改代码
主要加入一个排序函数:
void sort_list(Linklist pHeader)
{
NodePtr pre,p,q,tail=NULL;
while(pHeader->next!=tail)
{
pre=pHeader;
p=pHeader->next;
q=p->next;
while(p->next!=tail)
{
if(p->exponent>q->exponent)
{
pre->next=q;
p->next=q->next;
q->next=p;
}
else
{
p=p->next;
}
q=p->next;
pre=pre->next;
}
tail=p;
}
}
完整代码:
#include<stdio.h>
#include<malloc.h>
typedef struct LinkNode
{
int coefficient;//系数
int exponent;//指数
struct LinkNode *next;
}*Linklist,*NodePtr;
Linklist initLinklist()
{
Linklist tempHeader = (Linklist)malloc(sizeof(struct LinkNode));
tempHeader->coefficient = 0;
tempHeader->exponent = 0;
tempHeader->next = NULL;
return tempHeader;
}
void printlist(Linklist pHeader)
{
NodePtr p=pHeader->next;
while(p)
{
printf("%d * 10^%d + ",p->coefficient, p->exponent);
p=p->next;
}
printf("\n");
}
void printNode(NodePtr pPtr,char pchar)
{
if(pPtr==NULL)
{
printf("NULL!\n");
}
else
{
printf("The element of %c is (%d * 10^%d)\n",pchar,pPtr->coefficient,pPtr->exponent);
}
}
void appendelement(Linklist pHeader,int pcoefficient,int pexponent)
{
NodePtr p,q;
q=(NodePtr)malloc(sizeof(struct LinkNode));
q->coefficient=pcoefficient;
q->exponent=pexponent;
q->next=NULL;
p=pHeader;
while(p->next)
{
p=p->next;
}
p->next=q;
}
void add(NodePtr plist1,NodePtr plist2)
{
NodePtr p,q,r,s;
p=plist1->next;
q=plist2->next;
r=plist1;
free(plist2);
while((p!=NULL) && (q!=NULL))
{
if(p->exponent<q->exponent)
{
r->next=p;
r=p;
p=p->next;
}
else if(p->exponent>q->exponent)
{
r->next=q;
r=q;
q=q->next;
}
else
{
p->coefficient=p->coefficient +q->coefficient;
printf("The coefficient is: %d\n",p->coefficient);
if(p->coefficient==0)
{
s=p;
p=p->next;
}
else
{
r=p;
p=p->next;
}
s=q;
q=q->next;
free(s);
}
}
if(p==NULL)
{
r->next=q;
}
else
{
r->next=p;
}
printf("addition ends.\n");
}
void text()
{
Linklist templist1=initLinklist();
appendelement(templist1,7,0);
appendelement(templist1,3,17);
appendelement(templist1,9,8);
appendelement(templist1,5,5);
printf("未排序的list1:");
printlist(templist1);
sort_list(templist1);
printf("排序后的list1:");
printlist(templist1);
printf("\r\n");
Linklist templist2=initLinklist();
appendelement(templist2,8,1);
appendelement(templist2,22,7);
appendelement(templist2,-9,8);
printf("未排序的list2:");
printlist(templist2);
sort_list(templist2);
printf("排序后的list2:");
printlist(templist2);
printf("\r\n");
add(templist1,templist2);
printlist(templist1);
}
void sort_list(Linklist pHeader)
{
NodePtr pre,p,q,tail=NULL;
while(pHeader->next!=tail)
{
pre=pHeader;
p=pHeader->next;
q=p->next;
while(p->next!=tail)
{
if(p->exponent>q->exponent)
{
pre->next=q;
p->next=q->next;
q->next=p;
}
else
{
p=p->next;
}
q=p->next;
pre=pre->next;
}
tail=p;
}
}
void main()
{
text();
}
运行结果:
未排序的list1:7 * 10^0 + 3 * 10^17 + 9 * 10^8 + 5 * 10^5 +
排序后的list1:7 * 10^0 + 5 * 10^5 + 9 * 10^8 + 3 * 10^17 +
未排序的list2:8 * 10^1 + 22 * 10^7 + -9 * 10^8 +
排序后的list2:8 * 10^1 + 22 * 10^7 + -9 * 10^8 +
The coefficient is: 0
addition ends.
7 * 10^0 + 8 * 10^1 + 5 * 10^5 + 22 * 10^7 + 3 * 10^17 +
三、总结
其实更改后的代码还存在一些问题。例如,如果链表比较长,存在多个指数相同的项时,并不能将他们完全相加,结果还是会存在同类项。还有一些测试用例跑出来,结果可能存在系数为零的项。所以,该代码仍需改进。