需要优化此代码:
import java.lang.annotation.Annotation;
import java.lang.reflect.Method;
import javax.ws.rs.CookieParam;
import javax.ws.rs.FormParam;
import javax.ws.rs.HeaderParam;
import javax.ws.rs.MatrixParam;
import javax.ws.rs.Path;
import javax.ws.rs.PathParam;
import javax.ws.rs.QueryParam;
...
private String valueParam(Annotation a) {
String value = "";
if (a.annotationType() == QueryParam.class) {
value = ((QueryParam) a).value();
} else if (a.annotationType() == PathParam.class) {
value = ((PathParam) a).value();
} else if (a.annotationType() == CookieParam.class) {
value = ((CookieParam) a).value();
} else if (a.annotationType() == HeaderParam.class) {
value = ((HeaderParam) a).value();
} else if (a.annotationType() == MatrixParam.class) {
value = ((MatrixParam) a).value();
} else if (a.annotationType() == FormParam.class) {
value = ((FormParam) a).value();
}
return value;
}
SonarQube抱怨这种方法的复杂性.
改变它并不容易,因为我们需要在获取其值之前检查注释类型!
注意:陷阱位于Annotation接口上,该接口没有value()方法.
附: :此代码基于此example(代码示例4)