【设计模式】代码对比

1. 不好的代码

1.1 Shape.h

class Point{
	int x;
	int y;
};

class Line{
public:
	Point start;
	Point end;
	
	Line(const Point& start, const Point& end){
		this->start = start;
		this->end = end;
	}
};

class Rect{
public:
	Point leftUp;
	int width;
	int height;
	
	Rect(const Point& leftUp, int width, int height){
		this->leftUp = leftUp;
		this->width = width;
		this->height = height;
	}
	
};

1.2 MainForm.cpp

class MainForm : public Form{
private:
	Point p1;
	Point P2;
	
	vector<Line> lineVector;
	vector<Rect> rectVector;
	
public:
	MainForm(){
		//...
	}
	
protected:
	virtual void OnMouseDown(const MouseEventArgs& e);
	virtual void OnMouseUp(const MouseEventArgs& e);
	virtual void OnPaint(const PaintEventArgs& e);

}

void MainForm::OnMouseDown(const MouseEventArgs& e){
	p1.x = e.X;
	p1.y = e.Y;
	
	//...
	Form::OnMouseDown(e);
}

void MainForm::OnMouseUp(const MouseEventArgs& e){
	p2.x = e.X;
	p2.y = e.Y;
	
	if(rdoLine.Checked){
		Line line(p1, p2);
		lineVector.push_back(line);
	}else if(rdoRect.Checked){
		int width = abs(p2.x - p1.x);
		int height = abs(p2.y - p1.y);
		Rect rect(p1, width, height);
		rectVector.push_back(rect);
	}
	
	//...
	this->Refresh();
	
	Form::OnMouseUp(e);
}

void MainForm::OnPaint(const PaintEventArgs& e){
	//针对直线
	for(int i=0; i<lineVector.size(); i++){
		e.Graphics.DrawLine(Pens.Red,
			lineVector[i].start.x,
			lineVector[i].start.y,
			lineVector[i].end.x,
			lineVector[i].end.y);
	}
	
	//针对矩形
	for(int i=0; i<rectVector.size(); i++){
		e.Graphics.DrawRectangle(Pens.Red,
			rectVector[i].leftUp,
			rectVector[i].width,
			rectVector[i].height);
	}
	
	//...
	Form::OnPaint(e);
}

2. 好的代码

2.1 Shape.h

class Shape{
public:
	virtual void Draw(const Graphics& g) = 0;
	virtual ~Shape(){ }
};

class Point{
public:
	int x;
	int y;
};

class Line : public Shape{
public: 
	Point start;
	Point end;
	
	Line(const Point& start, const Point& end){
		this->start = start;
		this->end = end;
	}
	
	//实现自己的Draw, 负责画自己
	virtual void Draw(const Graphics& g){
		g.DrawLine(Pens.Red, start.x, start.y, end.x, end.y);
	}
};

class Rect : public Shape{
public:
	Point leftUp;
	int width;
	int height;
	
	Rect(const Point& leftUp, int width, int height){
		this->leftUp = leftUp;
		this->width = width;
		this->height = height;
	}
	
	//实现自己的Draw, 负责画自己
	virtual void Draw(const Graphics& g){
		g.DrawRectangle(Pens.Red, leftUp, width, height);
	}
};

2.2 MainForm.cpp

class MainForm : public Form{
private:
	Point p1;
	Point p2;
	
	//针对所有形状
	vector<Shape*> shapeVector;
	
public:
	MainForm(){
		//...
	}
	
protected:
	virtual void OnMouseDown(const MouseEventArgs& e);
	virtual void OnMouseUp(const MouseEventArgs& e);
	virtual void OnPaint(const PaintEventArgs& e);
}

void MainForm::OnMouseDown(const MouseEventArgs& e){
	p1.x = e.X;
	p1.y = e.Y;
	
	//...
	Form::OnMouseDown(e);
}

void MainForm::OnMouseUp(const MouseEventArgs& e){
	p2.x = e.X;
	p2.y = e.Y;
	
	if(rdoLine.Checked){
		lineVector.push_back(new Line(p1, p2));
	}else if(rdoRect.Checked){
		int width = abs(p2.x - p1.x);
		int height = abs(p2.y - p1.y);
		rectVector.push_back(new Rect(p1, width, height));
	}
	
	//...
	this->Refresh();
	
	Form::OnMouseUp(e);
}

void MainForm::OnPaint(const PaintEventArgs& e){
	//针对所有形状
	for(int i=0; i<shapeVector.size(); i++){
		shapeVector[i]->Draw(e.Graphics); //多态调用，各负其责
	}
	
	//...
	Form::OnPaint(e);
}