Poor Error Handling: Return Inside Finally

1、摘要

finally块内部返回，这将导致异常丢失，

2、解释

finally块中的return语句将导致丢弃try块中可能引发的任何异常。

3、例子

public static class MagicException extends Exception { }
public static void main(String[] args) {
System.out.println("Watch as this magical code makes an " +
"exception disappear before your very eyes!");
System.out.println("First, the kind of exception handlingyou're used to:");
try {
	doMagic(false);
} catch (MagicException e) {
	// An exception will be caught here
	e.printStackTrace();
}
System.out.println("Now, the magic:");
try {
	doMagic(true);
} catch (MagicException e) {
	// No exception caught here, the finally block ate it
	e.printStackTrace();
}
	System.out.println("tada!");
}
public static void doMagic(boolean returnFromFinally)
throws MagicException {
try {
	throw new MagicException();
}
finally {
	if (returnFromFinally) {
	return;
			}
 		}
 	}
 }

4、建议及提醒

	将return语句移到finally块之外。如果必须返回finally块内部的值，只需
将其赋给一个局部变量，并在finally块执行后返回该值。
	Fortify静态代码分析器将检测显式抛出以及对在finally块中抛出未捕获
异常的方法的调用。