> > > Hi, thanks response quickly!
> > > I thank maybe i did't say more clear. I mean that last_sequence_delivered and strmseq are uint16_t type in all FreeBSD branches.
> > > my worry is that:if last_sequence_delivered equal 0xFFFF, then the following compare sentence will cause some error:
> > > if ((asoc->strmin[strmno].last_sequence_delivered + 1) == strmseq)
> > > .........
> > > this sentence is in sctp_process_a_data_chunk of FB.
> > > because compiler will scale last_sequence_delivered to 32 bit when add 1, if last_sequence_delivered equal 0xFFFF, then (asoc->strmin[strmno].last_sequence_delivered + 1) will be 0x10000, rather than 0x0.
> > > so i think we should add a type_cast before the sentence like this:
> > > I thank maybe i did't say more clear. I mean that last_sequence_delivered and strmseq are uint16_t type in all FreeBSD branches.
> > > my worry is that:if last_sequence_delivered equal 0xFFFF, then the following compare sentence will cause some error:
> > > if ((asoc->strmin[strmno].last_sequence_delivered + 1) == strmseq)
> > > .........
> > > this sentence is in sctp_process_a_data_chunk of FB.
> > > because compiler will scale last_sequence_delivered to 32 bit when add 1, if last_sequence_delivered equal 0xFFFF, then (asoc->strmin[strmno].last_sequence_delivered + 1) will be 0x10000, rather than 0x0.
> > > so i think we should add a type_cast before the sentence like this:
> > > if ((uint16_t)(asoc->strmin[strmno].last_sequence_delivered + 1) == strmseq)
1万+
被折叠的 条评论
为什么被折叠?
到【灌水乐园】发言
