I verified that the migration works if you first update -devkit/schematics to >= 8.1.1. We don't want to pin the version for the package in the package.json, as it already has a direct dependency with the Angular CLI. I'll look at a fix to update the version before running the migration so it can continue successfully.

Support for /entity as part of the ngrx schematic was added in Nx 8.3. Use the --syntax=creators option

can you verify this is still an issue with the latest release?

the Slack invite link has expired. Will you post a new one?

Can this issue be closed or is there something remaining that needs to be documented?

Thanks for hanging in there !

Yep :-) Your commit message still needs a tweak

I'm still seeing multiple commits here: https://github.com/nrwl/nx/pull/3301/commits

yep. Locally in your fork:

1. Add the nx repo as upstream, you only need to do this once

sh
git add upstream git.com:nrwl/nx.git

1. Fetch upstream master branch

sh
git fetch upstream master

1. Checkout your master branch

sh
git checkout master

1. Pull latest from upstream master branch

sh
git pull upstream master

1. Checkout your branch

sh
git checkout fix-symlink-check-file-exists

1. Rebase on top of the master branch

sh
git rebase master --interactive

Use the command line GUI to squash the commits into a single commit, with the correct commit message

1. Force push your branch back to your origin

sh
git push origin fix-symlink-check-file-exists --force-with-lease

will you rebase on master? That should fix the e2e test error

You may need to rebase on master to fix those, could have also just been a flaky test. It will re-run them when you push the commit up

will you update the commit message to fix(angular): check for file to exist in decorate script

Closing as resolved

Thanks -rafigh

I'm working an update to the ngrx schematics to support action creators https://github.com/nrwl/nx/pull/1550

Yes, that is still the recommended way as defined in that doc, as we only want to run ngcc when node_modules change.

https://angular.io/guide/ivy#speeding-up-ngcc-compilation

If you have a reproduction of the error, it may need to be filed in the https://github.com/angular/angular repo to be fixed in ngcc upstream, or even by the third-party library.

We have fixed this upstream in NgRx so that you can use the serialization/immutability checks with the full router state, so these workarounds aren't needed. See https://github.com/ngrx/platform/pull/2491 and https://github.com/ngrx/platform/pull/2351 for context

Ideally, you would land the updates to Nx in master, and then merge/rebase the other branches on top of those changes. This is outside the scope of Nx though

I have a test for the models file here https://github.com/nrwl/nx/pull/1550/files#diff-9cf1f28d0209d3021f9d79dfca3b67f2R626

I reverted the delegation to /schematics, and updated the imports to follow the same general practices for setup. I also added the --routing option to the test to make sure it continues functioning during future changes.

thanks for review. Is the installation of the packages not guaranteed if we modify the package.json and add an install task before the schematics are run?

Still working on adding a migration to /angular for breaking changes in NgRx 8. Hoping to use existing upstream migrations

Yes, that would help

can you reproduce this within a small repo?

I wasn't able to reproduce this. Will you provide a repo?

Thanks

Yes

Will you rebase on master again to fix the merge conflicts? Thanks

will you rebase this PR on master, and revert the changes to the scripts?

if you're primarily using Angular, you should be using the ng commands like they are in the Angular tutorial. If you're primarily using React or Web Components, you should be using the nx commands. The difference is that there is only a workspace.json when primarily only using React or Web Components. The nx command delegates appropriately, but we could define this more clearly in the docs for the Nx CLI here: https://nx.dev/react/guides/cli

are you using Angular primarily? If you are, you should power your workspace using the Angular CLI and use the ng commands. The Nx CLI is primarily for react and web component projects at the moment.

Nx does not currently support an add command, but the command to run when using the Angular CLI is ng add /pwa --project my-app. If you want to run it manually, try:

ts
yarn add /pwa --dev
nx g /pwa:ng-add --project my-app

Circling back on this and I'm a little unclear to the request ... What is the intended goal?

The PR for clarifying usage with the creators syntax is still open, but this issue has been resolved.

Sounds good. Just open an issue first and tag me.

I agree that the schematics we have in the platform cover those things already.

This issue has been fixed

Thanks . Feel free to reopen this issue if you're still having problems

I tried to reproduce this using the following commands:

sh
npx /cli.1.0 new ng3285
cd ng3285
ng add /workspace

After running those commands, I looked at the apps/ng3285/tsconfig.app.json and it looks correct to me.

ts
{
  "extends": "../../tsconfig.json",
  "compilerOptions": {
    "outDir": "../../dist/out-tsc",
    "types": []
  },
  "files": [
    "src/main.ts",
    "src/polyfills.ts"
  ],
  "include": [
    "src/**/*.d.ts"
  ]
}

Is there some more specific reproduction instructions you can provide?

Do you mean ng add /workspace? /schematics should no longer be used with version 8 and later.

in company where i work i would like to introduce nx in one of our project, but because of issue with automate migration it is much harder, when can we expect to release this functionality?

It should land in the Nx 10.4 release coming soon.