【代码审查】C#常见的错误提醒

Resources should be closed

 资源未关闭，打开发现有两处用到的IO流没有关闭

 

Conditions should not unconditionallyevaluate to "TRUE" or to "FALSE"

if/else判断里出现了重复判断，比如在if(a>10)的执行体里面又判断if(a<0)，而后者肯定不会是true

 

Exception handlers should preserve theoriginal exception 

处理异常的时候应该保留原始的异常情况，不要直接来个catch(Exception e)了事

  

Throwable.printStackTrace(...) should notbe called

不应该直接调用e.printStackTrace()，而是用Loggers来处理（就是打Log）。 

Loggers的优势是：Users are ableto easily retrieve the logs.

The format of log messages is uniform andallow users to browse the logs easily.

 

Instance methods should not write to"static" fields

 不要用实例方法改变静态成员，理想情况下，静态变量只通过同步的静态方法来改变

"public static" fields should beconstant

公共静态成员应该加上final，也就是public static final 一般不分家

 

Threa