回头看——《智能家居项目小结》

Alo723

已于 2023-02-12 12:17:36 修改

阅读量239

点赞数

分类专栏：驱动开发智能家居系统文章标签：智能家居 c语言 Powered by 金山文档

于 2023-02-11 23:03:55 首次发布

本文链接：https://blog.csdn.net/weixin_66861497/article/details/128990314

版权

驱动开发同时被 2 个专栏收录

11 篇文章 1 订阅

订阅专栏

智能家居系统

3 篇文章 0 订阅

订阅专栏

文章展示了如何使用OpenAI对C语言代码进行优化，包括TCP服务器初始化函数(TCP_SER_INIT)的改进，将错误检查与操作合并，以及手动控制线程代码的重构，通过创建设备数组简化LED、蜂鸣器、风扇和电机的控制逻辑，提高代码可维护性。

摘要由CSDN通过智能技术生成

openAI兴起，于是拿着之前小组合作的项目（承认优化较差），交给AI试着帮忙优化下

一时兴起，做到哪里写到哪里

１.功能函数（TCP_SER_INIT）优化

原代码：

int TCP_SER_INIT(int *tcpsocket, const char *ip, const char *port)
{
    int res, optval = 1;

    // TCP通信结构体构建
    struct sockaddr_in ser = {
        .sin_family = AF_INET,
        .sin_port = htons((short)atoi(port)),
        .sin_addr.s_addr = inet_addr(ip),
    };

    *tcpsocket = socket(AF_INET, SOCK_STREAM, 0);
    if (-1 == *tcpsocket)
    {
        ERR_MSG("socket");
        return -1;
    }

    // 允许端口快速重复使用
    res = setsockopt(*tcpsocket, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval));
    if (-1 == res)
    {
        ERR_MSG("setsockopt");
        return -1;
    }

    res = bind(*tcpsocket, (struct sockaddr *)&ser, sizeof(ser));
    if (-1 == res)
    {
        ERR_MSG("bind");
        return -1;
    }

    res = listen(*tcpsocket, 128);
    if (-1 == res)
    {
        ERR_MSG("listen");
        return -1;
    }

    printf("等待客户端链接...\n");
    return 0;
}

优化后代码：

int TCP_SER_INIT(int *tcpsocket, const char *ip, const char *port)
{
    int optval = 1;

    // TCP通信结构体构建
    struct sockaddr_in ser = {
        .sin_family = AF_INET,
        .sin_port = htons((short)atoi(port)),
        .sin_addr.s_addr = inet_addr(ip),
    };

    if ((*tcpsocket = socket(AF_INET, SOCK_STREAM, 0)) == -1)
    {
        ERR_MSG("socket");
        return -1;
    }

    if (setsockopt(*tcpsocket, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval)) == -1)
    {
        ERR_MSG("setsockopt");
        return -1;
    }

    if (bind(*tcpsocket, (struct sockaddr *)&ser, sizeof(ser)) == -1)
    {
        ERR_MSG("bind");
        return -1;
    }

    if (listen(*tcpsocket, 128) == -1)
    {
        ERR_MSG("listen");
        return -1;
    }

    printf("等待客户端链接...\n");
    return 0;
}

反思：

优化前后的差别：优化前，主要出现在每一次操作之后都要判断操作是否成功，返回相应的值；优化后，通过将操作结果判断和返回值放在操作一起，简化了代码，使之更加简洁易读。

２.手动控制线程代码优化

原代码：

void *pthread_manual(void *arg)
{
    while (1)
    {
        int which;
        msg_t *sendmsg = (msg_t *)arg;

        if (sendmsg->type & LED1_ON)
        {
            which = 1;
            ioctl(fd_led1, IO_LED_ON, &which);
        }
        if (sendmsg->type & LED1_OFF)
        {
            which = 1;
            ioctl(fd_led1, IO_LED_OFF, &which);
        }

        if (sendmsg->type & LED2_ON)
        {
            which = 2;
            ioctl(fd_led2, IO_LED_ON, &which);
        }
        if (sendmsg->type & LED2_OFF)
        {
            which = 2;
            ioctl(fd_led2, IO_LED_OFF, &which);
        }

        if (sendmsg->type & LED3_ON)
        {
            which = 3;
            ioctl(fd_led3, IO_LED_ON, &which);
        }
        if (sendmsg->type & LED3_OFF)
        {
            which = 3;
            ioctl(fd_led3, IO_LED_OFF, &which);
        }

        if (sendmsg->type & BUZZER_ON)
        {
            ioctl(fd_buzzer, IO_BUZZER_ON);
        }
        if (sendmsg->type & BUZZER_OFF)
        {
            ioctl(fd_buzzer, IO_BUZZER_OFF);
        }

        if (sendmsg->type & FAN_ON)
        {
            ioctl(fd_fan, IO_FAN_ON);
        }
        if (sendmsg->type & FAN_OFF)
        {
            ioctl(fd_fan, IO_FAN_OFF);
        }

        if (sendmsg->type & MOTOR_ON)
        {
            ioctl(fd_motor, IO_MOTOR_ON);
        }
        if (sendmsg->type & MOTOR_OFF)
        {
            ioctl(fd_motor, IO_MOTOR_OFF);
        }
    }
}

优化后代码：

 void *pthread_manual(void *arg)
{
    while (1)
    {
        msg_t *sendmsg = (msg_t *)arg;
        int device[3] = {1, 2, 3};

        if (sendmsg->type & LED1_ON)
        {
            ioctl(fd_led1, IO_LED_ON, &device[0]);
        }
        if (sendmsg->type & LED1_OFF)
        {
            ioctl(fd_led1, IO_LED_OFF, &device[0]);
        }
        if (sendmsg->type & LED2_ON)
        {
            ioctl(fd_led2, IO_LED_ON, &device[1]);
        }
        if (sendmsg->type & LED2_OFF)
        {
            ioctl(fd_led2, IO_LED_OFF, &device[1]);
        }
        if (sendmsg->type & LED3_ON)
        {
            ioctl(fd_led3, IO_LED_ON, &device[2]);
        }
        if (sendmsg->type & LED3_OFF)
        {
            ioctl(fd_led3, IO_LED_OFF, &device[2]);
        }
        if (sendmsg->type & BUZZER_ON)
        {
            ioctl(fd_buzzer, IO_BUZZER_ON);
        }
        if (sendmsg->type & BUZZER_OFF)
        {
            ioctl(fd_buzzer, IO_BUZZER_OFF);
        }
        if (sendmsg->type & FAN_ON)
        {
            ioctl(fd_fan, IO_FAN_ON);
        }
        if (sendmsg->type & FAN_OFF)
        {
            ioctl(fd_fan, IO_FAN_OFF);
        }
        if (sendmsg->type & MOTOR_ON)
        {
            ioctl(fd_motor, IO_MOTOR_ON);
        }
        if (sendmsg->type & MOTOR_OFF)
        {
            ioctl(fd_motor, IO_MOTOR_OFF);
        }
    }
}